* [PATCH v2] crypto: vmx - VMX crypto should depend on CONFIG_VSX
@ 2015-09-09 8:22 Michael Ellerman
2015-09-10 9:26 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2015-09-09 8:22 UTC (permalink / raw)
To: linuxppc-dev; +Cc: leosilva, herbert, Paul Mackerras, tim.gardner, linux-crypto
This code uses FP (floating point), Altivec and VSX (Vector-Scalar
Extension). It can just depend on CONFIG_VSX though, because that
already depends on FP and Altivec.
Otherwise we get lots of link errors such as:
drivers/built-in.o: In function `.p8_aes_setkey':
aes.c:(.text+0x2d325c): undefined reference to `.enable_kernel_altivec'
aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx'
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
v2: Spell out VSX, and CC linux-crypto.
drivers/crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 07bc7aa6b224..d234719065a5 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -461,7 +461,7 @@ config CRYPTO_DEV_QCE
config CRYPTO_DEV_VMX
bool "Support for VMX cryptographic acceleration instructions"
- depends on PPC64
+ depends on PPC64 && VSX
help
Support for VMX cryptographic acceleration instructions.
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] crypto: vmx - VMX crypto should depend on CONFIG_VSX
2015-09-09 8:22 [PATCH v2] crypto: vmx - VMX crypto should depend on CONFIG_VSX Michael Ellerman
@ 2015-09-10 9:26 ` Herbert Xu
2015-09-11 0:47 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Herbert Xu @ 2015-09-10 9:26 UTC (permalink / raw)
To: Michael Ellerman
Cc: linuxppc-dev, leosilva, Paul Mackerras, tim.gardner, linux-crypto
On Wed, Sep 09, 2015 at 06:22:35PM +1000, Michael Ellerman wrote:
> This code uses FP (floating point), Altivec and VSX (Vector-Scalar
> Extension). It can just depend on CONFIG_VSX though, because that
> already depends on FP and Altivec.
>
> Otherwise we get lots of link errors such as:
>
> drivers/built-in.o: In function `.p8_aes_setkey':
> aes.c:(.text+0x2d325c): undefined reference to `.enable_kernel_altivec'
> aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx'
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] crypto: vmx - VMX crypto should depend on CONFIG_VSX
2015-09-10 9:26 ` Herbert Xu
@ 2015-09-11 0:47 ` Michael Ellerman
2015-09-11 0:50 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2015-09-11 0:47 UTC (permalink / raw)
To: Herbert Xu
Cc: linuxppc-dev, leosilva, Paul Mackerras, tim.gardner, linux-crypto
On Thu, 2015-09-10 at 17:26 +0800, Herbert Xu wrote:
> On Wed, Sep 09, 2015 at 06:22:35PM +1000, Michael Ellerman wrote:
> > This code uses FP (floating point), Altivec and VSX (Vector-Scalar
> > Extension). It can just depend on CONFIG_VSX though, because that
> > already depends on FP and Altivec.
> >
> > Otherwise we get lots of link errors such as:
> >
> > drivers/built-in.o: In function `.p8_aes_setkey':
> > aes.c:(.text+0x2d325c): undefined reference to `.enable_kernel_altivec'
> > aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx'
> >
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Applied.
Thanks.
Is that targeted for 4.3 ?
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-11 0:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-09 8:22 [PATCH v2] crypto: vmx - VMX crypto should depend on CONFIG_VSX Michael Ellerman
2015-09-10 9:26 ` Herbert Xu
2015-09-11 0:47 ` Michael Ellerman
2015-09-11 0:50 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).