linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: mpe@ellerman.id.au, aneesh.kumar@linux.vnet.ibm.com, mikey@neuling.org
Subject: [RFC] powerpc/hugetlb: Add warning message when gpage allocation request fails
Date: Mon, 14 Sep 2015 11:57:31 +0530	[thread overview]
Message-ID: <1442212051-15235-1-git-send-email-khandual@linux.vnet.ibm.com> (raw)

When a 16GB huge page is requested on POWER platform through kernel command
line interface, it silently fails because of the lack of any gigantic pages
on the system which the platform should have communicated through 16GB memory
blocks in the device tree during boot time. For example

[    0.480940] HugeTLB registered 16 GB page size, pre-allocated 0 pages
[    0.480945] HugeTLB registered 16 MB page size, pre-allocated 16 pages

This adds a warning message during alloc_bootmem_huge_page request both on
book3e and book3s powerpc platforms. After this change

[    0.000000] Gigantic HugeTLB page not available
[    0.473417] HugeTLB registered 16 GB page size, pre-allocated 0 pages
[    0.473423] HugeTLB registered 16 MB page size, pre-allocated 16 pages

Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
---
 arch/powerpc/mm/hugetlbpage.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index 06c1452..54f3e42 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -307,8 +307,10 @@ int alloc_bootmem_huge_page(struct hstate *hstate)
 	int idx = shift_to_mmu_psize(huge_page_shift(hstate));
 	int nr_gpages = gpage_freearray[idx].nr_gpages;
 
-	if (nr_gpages == 0)
+	if (nr_gpages == 0) {
+		printk(KERN_WARNING "Gigantic HugeTLB page not available\n");
 		return 0;
+	}
 
 #ifdef CONFIG_HIGHMEM
 	/*
@@ -429,8 +431,10 @@ void add_gpage(u64 addr, u64 page_size, unsigned long number_of_pages)
 int alloc_bootmem_huge_page(struct hstate *hstate)
 {
 	struct huge_bootmem_page *m;
-	if (nr_gpages == 0)
+	if (nr_gpages == 0) {
+		printk(KERN_WARNING "Gigantic HugeTLB page not available\n");
 		return 0;
+	}
 	m = phys_to_virt(gpage_freearray[--nr_gpages]);
 	gpage_freearray[nr_gpages] = 0;
 	list_add(&m->list, &huge_boot_pages);
-- 
2.1.0

             reply	other threads:[~2015-09-14  6:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14  6:27 Anshuman Khandual [this message]
2015-09-14 13:29 ` [RFC] powerpc/hugetlb: Add warning message when gpage allocation request fails Aneesh Kumar K.V
2015-09-14 16:24   ` Nishanth Aravamudan
2015-09-14 23:55     ` Michael Ellerman
2015-09-15  3:43     ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442212051-15235-1-git-send-email-khandual@linux.vnet.ibm.com \
    --to=khandual@linux.vnet.ibm.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).