From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0120.outbound.protection.outlook.com [65.55.169.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id C820B1A035C for ; Wed, 16 Sep 2015 12:19:31 +1000 (AEST) Message-ID: <1442369955.2909.166.camel@freescale.com> Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM From: Scott Wood To: Wang Dongsheng-B40534 CC: "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , Wang Huan-B18965 , Jin Zhengxiong-R64188 , Zhao Chenhui-B35336 , Tang Yuantian-B29983 Date: Tue, 15 Sep 2015 21:19:15 -0500 In-Reply-To: References: <1442307339-15225-1-git-send-email-dongsheng.wang@freescale.com> <1442361398.2909.164.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 16, 2015 7:57 AM > > To: Wang Dongsheng-B40534 > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan- > > B18965; Jin > > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983 > > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM > > > > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote: > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > +------------------------------------------- > > > +Required rcpm-wakeup property should be added to a device node if the > > > device > > > +can be used as a wakeup source. > > > + > > > + - rcpm-wakeup: The value of the property consists of 3 cells. The > > > first > > > cell > > > + is a pointer to the rcpm node, the second cell is the bit mask > > > that > > > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1. > > > + Note: If the platform has no IPPDEXPCR1 register, put a zero here. > > > > What if a future platform has more than two of these registers? > > Those registers are only used for wakeup device, we have a lot of available > bit > for feature. For example, In LS1021a platform only 7bits has used in the > registers, > and 57bits is reserved. Still, it'd be better to for the rcpm node to advertise the number of cells it expects. -Scott