From: Michael Ellerman <mpe@ellerman.id.au>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: benh@kernel.crashing.org, paulus@samba.org, anton@samba.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch-powerpc: Return false instead of -EFAULT
Date: Thu, 17 Sep 2015 19:47:34 +1000 [thread overview]
Message-ID: <1442483254.26748.5.camel@ellerman.id.au> (raw)
In-Reply-To: <1442481536-11088-1-git-send-email-peter.senna@gmail.com>
On Thu, 2015-09-17 at 11:18 +0200, Peter Senna Tschudin wrote:
> Returning a negative value for a boolean function seem to have the
> undesired effect of returning true. Replace -EINVAL by false in a
> bool-returning function.
>
> The diff of the .s file before and after the change (using cross
> compilation) starts with:
>
> 440,441c440,441
> < .L43:
> < li 3,1 # D.25775,
> ---
> > .L42:
> > li 3,0 # D.25775,
> ...
>
> while if -EFAULT is replaced by true, the diff is empty.
Ah, that's rather unfortunate.
Can you post the full asm listing, for all three cases?
cheers
next prev parent reply other threads:[~2015-09-17 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 9:18 [PATCH] arch-powerpc: Return false instead of -EFAULT Peter Senna Tschudin
2015-09-17 9:47 ` Michael Ellerman [this message]
2015-09-17 9:58 ` Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442483254.26748.5.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).