From: Scott Wood <scottwood@freescale.com>
To: Jia Hongtao <hongtao.jia@freescale.com>
Cc: <linuxppc-dev@lists.ozlabs.org>, <devicetree@vger.kernel.org>,
<robh+dt@kernel.org>
Subject: Re: [PATCH] PowerPC: Move Freescale device tree files into fsl folder
Date: Thu, 17 Sep 2015 23:48:19 -0500 [thread overview]
Message-ID: <1442551699.19102.99.camel@freescale.com> (raw)
In-Reply-To: <1442548824-45849-1-git-send-email-hongtao.jia@freescale.com>
On Fri, 2015-09-18 at 12:00 +0800, Jia Hongtao wrote:
> It makes no sense that some Freescale device tree files are in fsl
> directory while some others not. This patch move Freescale device tree
> files into fsl folder. To do that the following two steps are made:
> - Move Freescale device tree files into fsl folder.
> - Update the include path in these files from "fsl/*.dtsi" to "*.dtsi".
>
> Please add "fsl/" prefix when you make dtb using Makefile.
The existing arrangement is indeed a bit odd, but the real reason for this is
the interaction with the preprocessor. If a dtsi uses preprocessor
directives, it needs to be included with #include rather than /include/, or
else the dtsi won't be preprocessed. However, if a dtsi is included with
#include, and that dtsi is in fsl/ but the including dts isn't, any
/include/s within the dtsi will not search that fsl/ because dtc doesn't
realize that's the directory the content came from.
There was a desire to include <dt-bindings/thermal/thermal.h> from
fsl/t1040si-post.dtsi. In order to make everything work, we need to either
move all relevant files to the same directory, or convert all /include/s in
affected files to #include.
-Scott
next prev parent reply other threads:[~2015-09-18 4:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 4:00 [PATCH] PowerPC: Move Freescale device tree files into fsl folder Jia Hongtao
2015-09-18 4:48 ` Scott Wood [this message]
2015-10-17 5:35 ` Scott Wood
-- strict thread matches above, loose matches on Subject: below --
2015-09-18 3:52 [PATCH] " Jia Hongtao
2015-09-18 4:11 ` Hongtao Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442551699.19102.99.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=hongtao.jia@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).