From: Thomas Huth <thuth@redhat.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
boqun.feng@gmail.com
Subject: [PATCH] powerpc: Kconfig.cputype: Disallow TUNE_CELL on LE systems
Date: Fri, 18 Sep 2015 16:17:00 +0200 [thread overview]
Message-ID: <1442585820-18623-1-git-send-email-thuth@redhat.com> (raw)
It looks somewhat weird that you can enable TUNE_CELL on little
endian systems, so let's disable this option with CPU_LITTLE_ENDIAN.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
I first thought that it might be better to make this option depend
on PPC_CELL instead ... but I guess it's a bad idea to depend a
CPU option on a platform option? Alternatively, would it make
sense to make it depend on (GENERIC_CPU || CELL_CPU) instead?
arch/powerpc/platforms/Kconfig.cputype | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
index c140e94..d93e131 100644
--- a/arch/powerpc/platforms/Kconfig.cputype
+++ b/arch/powerpc/platforms/Kconfig.cputype
@@ -149,7 +149,7 @@ config 6xx
config TUNE_CELL
bool "Optimize for Cell Broadband Engine"
- depends on PPC64 && PPC_BOOK3S
+ depends on PPC64 && PPC_BOOK3S && !CPU_LITTLE_ENDIAN
help
Cause the compiler to optimize for the PPE of the Cell Broadband
Engine. This will make the code run considerably faster on Cell
--
1.8.3.1
next reply other threads:[~2015-09-18 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 14:17 Thomas Huth [this message]
2015-09-21 7:18 ` [PATCH] powerpc: Kconfig.cputype: Disallow TUNE_CELL on LE systems Michael Ellerman
2015-09-21 10:07 ` Thomas Huth
2015-10-06 10:05 ` Michael Ellerman
2015-10-06 10:48 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442585820-18623-1-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).