From: Michael Ellerman <mpe@ellerman.id.au>
To: Kevin Hao <haokexin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH] powerpc: fsl_pci: cast the regs->nip to void * when passing it to probe_kernel_address()
Date: Tue, 22 Sep 2015 12:08:17 +1000 [thread overview]
Message-ID: <1442887697.18408.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1442827370-26854-1-git-send-email-haokexin@gmail.com>
On Mon, 2015-09-21 at 17:22 +0800, Kevin Hao wrote:
> With the reimplementation of probe_kernel_address() in commit
> ecc83243e1d4 ("uaccess: reimplement probe_kernel_address() using
> probe_kernel_read()"), the explication of the cast for the addr
> parameter has been dropped. So we have to explicitly cast the
> regs->nip to void * when passing it to probe_kernel_address() in
> order to fix the following build error:
> arch/powerpc/sysdev/fsl_pci.c: In function 'fsl_pci_mcheck_exception':
> arch/powerpc/sysdev/fsl_pci.c:1002:4: error: passing argument 2 of 'probe_kernel_read' makes pointer from integer without a cast [-Werror]
> ret = probe_kernel_address(regs->nip, inst);
> ^
>
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
> ---
>
> This is against linux-next.
You should be sending this to Andrew Morton, the author of the patch that
caused the breakage. Or at the very least CC'ing him.
cheers
next prev parent reply other threads:[~2015-09-22 2:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 9:22 [PATCH] powerpc: fsl_pci: cast the regs->nip to void * when passing it to probe_kernel_address() Kevin Hao
2015-09-22 2:08 ` Michael Ellerman [this message]
2015-09-22 2:11 ` Kevin Hao
2015-09-22 2:16 ` Scott Wood
2015-09-22 2:25 ` Kevin Hao
2015-09-22 5:17 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442887697.18408.1.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=haokexin@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).