From: Scott Wood <scottwood@freescale.com>
To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
Jin Zhengxiong-R64188 <Jason.Jin@freescale.com>,
"Wang Huan-B18965" <alison.wang@freescale.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Zhao Chenhui-B35336 <chenhui.zhao@freescale.com>,
Tang Yuantian-B29983 <Yuantian.Tang@freescale.com>
Subject: Re: [PATCH v3 1/2] fsl: Add binding for RCPM
Date: Thu, 24 Sep 2015 21:43:52 -0500 [thread overview]
Message-ID: <1443149032.32298.102.camel@freescale.com> (raw)
In-Reply-To: <SN1PR0301MB161653CC69BB78A0A8B565569D420@SN1PR0301MB1616.namprd03.prod.outlook.com>
On Thu, 2015-09-24 at 21:38 -0500, Wang Dongsheng-B40534 wrote:
> > > +* Freescale RCPM Wakeup Source Device Tree Bindings
> > > +-------------------------------------------
> > > +Required rcpm-wakeup property should be added to a device node if the
> > > device
> > > +can be used as a wakeup source.
> > > +
> > > + - rcpm-wakeup: The value of the property consists of cells, the
> > > number of
> > > + cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a
> > > pointer
> > > + to the rcpm node, the second cell is the bit mask that should be
> > > set
> > > + in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on.
> >
> > The phandle should not be included in the cell count.
> >
>
> Yes, the first cell "&rcpm" should be in the cell count, right?
No. None of the other #foo-cells work that way.
-Scott
next prev parent reply other threads:[~2015-09-25 2:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 8:29 [PATCH v3 1/2] fsl: Add binding for RCPM Dongsheng Wang
2015-09-24 8:29 ` [PATCH v3 2/2] arm/layerscape: add RCPM device tree support for ls1021a Dongsheng Wang
2015-09-24 12:29 ` [PATCH v3 1/2] fsl: Add binding for RCPM Shawn Guo
2015-09-25 2:24 ` Wang Dongsheng
2015-09-24 19:30 ` Scott Wood
2015-09-25 2:38 ` Wang Dongsheng
2015-09-25 2:43 ` Scott Wood [this message]
2015-09-25 2:51 ` Wang Dongsheng
[not found] ` <CALRxmdDwGgxCG5SfSOaEXK8_fJcG4UUw_9D2=NA7nQhikDyb+A@mail.gmail.com>
2015-10-01 17:05 ` Stuart Yoder
2015-10-01 17:07 ` Scott Wood
2015-10-08 2:32 ` Wang Dongsheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443149032.32298.102.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Dongsheng.Wang@freescale.com \
--cc=Jason.Jin@freescale.com \
--cc=Yuantian.Tang@freescale.com \
--cc=alison.wang@freescale.com \
--cc=chenhui.zhao@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).