From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id E101E1A002B for ; Mon, 28 Sep 2015 18:58:14 +1000 (AEST) Message-ID: <1443430694.3171.6.camel@neuling.org> Subject: Re: [PATCH v2 1/2] powerpc/selftest: Add gettimeofday() benchmark From: Michael Neuling To: Gabriel Paubert Cc: Denis Kirjanov , Arnd Bergmann , Steve Munroe , anton@samba.org, Aaron Sawdey , linuxppc-dev@lists.ozlabs.org Date: Mon, 28 Sep 2015 18:58:14 +1000 In-Reply-To: <20150925093746.GA21535@visitor2.iram.es> References: <1443153700-15395-1-git-send-email-mikey@neuling.org> <1443153700-15395-2-git-send-email-mikey@neuling.org> <1474940.LhqZEdbX4W@wuerfel> <20150925093746.GA21535@visitor2.iram.es> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2015-09-25 at 11:37 +0200, Gabriel Paubert wrote: > On Fri, Sep 25, 2015 at 12:28:30PM +0300, Denis Kirjanov wrote: > > On 9/25/15, Arnd Bergmann wrote: > > > On Friday 25 September 2015 14:01:39 Michael Neuling wrote: > > >> This adds a benchmark directory to the powerpc selftests and adds a > > >> gettimeofday() benchmark to it. > > >> > > >> Suggested-by: Michael Ellerman > > >> Signed-off-by: Michael Neuling > > >> > > > > > > Any reason for keeping this powerpc specific? It seems generally usef= ul. > > > and portable. > > You're right. Moreover, we can put some comment to the benchmark why > > we've made such decision to add it (reference to the commit > > "powerpc/vdso: Avoid link stack corruption in __get_datapage()") >=20 > Why gettimeofday? Isn't clock_gettime the modern variant? We can do either here really. I just wanted to test __get_datapage() really. I just stole the benchmark from Anton, which turned into mpe wanting it in selftests. I dumped it in powerpc mostly because I knew mpe would take it (ie. I'm was being lazy). > BTW: dows anyone receive 2 copies of every messge in this thread ? I'm not. Mikey >=20 > I do, and I suspect that this is due to the Cc: list having both > linuxppc-dev@ozlabs.org and linuxppc-dev@lists.ozlabs.org. I removed the > former for this reply. >=20 > Gabriel