From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org,
Segher Boessenkool <segher@kernel.crashing.org>,
Denis Kirjanov <kda@linux-powerpc.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v3 3/5] powerpc/pseries: replace kmalloc + strlcpy
Date: Thu, 1 Oct 2015 12:46:08 +0300 [thread overview]
Message-ID: <1443692770-44944-4-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1443692770-44944-1-git-send-email-andriy.shevchenko@linux.intel.com>
The helper kstrndup() will do the same in one line.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/powerpc/platforms/pseries/of_helpers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/of_helpers.c b/arch/powerpc/platforms/pseries/of_helpers.c
index 2f363e3..8c6b05a 100644
--- a/arch/powerpc/platforms/pseries/of_helpers.c
+++ b/arch/powerpc/platforms/pseries/of_helpers.c
@@ -24,10 +24,9 @@ struct device_node *pseries_of_derive_parent(const char *path)
return ERR_PTR(-EINVAL);
if (strrchr(path, '/') != path) {
- parent_path = kmalloc(parent_path_len, GFP_KERNEL);
+ parent_path = kstrndup(path, parent_path_len, GFP_KERNEL);
if (!parent_path)
return ERR_PTR(-ENOMEM);
- strlcpy(parent_path, path, parent_path_len);
}
parent = of_find_node_by_path(parent_path);
if (strcmp(parent_path, "/"))
--
2.5.1
next prev parent reply other threads:[~2015-10-01 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 9:46 [PATCH v3 0/5] powerpc/pseries: bug fix and clean up Andy Shevchenko
2015-10-01 9:46 ` [PATCH v3 1/5] powerpc/pseries: extract of_helpers module Andy Shevchenko
2015-10-12 11:17 ` [v3,1/5] " Michael Ellerman
2015-10-01 9:46 ` [PATCH v3 2/5] powerpc/pseries: fix a potential memory leak Andy Shevchenko
2015-10-01 9:46 ` Andy Shevchenko [this message]
2015-10-01 9:46 ` [PATCH v3 4/5] powerpc/pseries: handle nodes without '/' Andy Shevchenko
2015-10-01 9:46 ` [PATCH v3 5/5] powerpc/pseries: re-use code from of_helpers module Andy Shevchenko
2015-10-01 19:26 ` [PATCH v3 0/5] powerpc/pseries: bug fix and clean up Denis Kirjanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443692770-44944-4-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=kda@linux-powerpc.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).