From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
Michael Neuling <mikey@neuling.org>
Cc: Aaron Sawdey <sawdey@us.ibm.com>,
Denis Kirjanov <kda@linux-powerpc.org>,
Steve Munroe <sjmunroe@us.ibm.com>,
linuxppc-dev@ozlabs.org, anton@samba.org
Subject: Re: [v2, 2/2] powerpc/vdso: Avoid link stack corruption in __get_datapage()
Date: Fri, 02 Oct 2015 18:24:50 +1000 [thread overview]
Message-ID: <1443774290.27295.4.camel@kernel.crashing.org> (raw)
In-Reply-To: <20151002074709.3AE4F140773@ozlabs.org>
On Fri, 2015-10-02 at 17:47 +1000, Michael Ellerman wrote:
> On Fri, 2015-25-09 at 04:01:40 UTC, Michael Neuling wrote:
> > powerpc has a link register (lr) used for calling functions. We "bl
> > <func>" to call a function, and "blr" to return back to the call
> > site.
>
> <snip, geez that was long>
>
> > For the benchmark in
> > tools/testing/selftests/powerpc/benchmarks/gettimeofday.c
> > POWER8:
> > 64bit gets ~4% improvement
> > 32bit gets ~9% improvement
> > POWER7:
> > 64bit gets ~7% improvement
> >
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> > Reported-by: Aaron Sawdey <sawdey@us.ibm.com>
>
> Applied to powerpc next, thanks.
>
> https://git.kernel.org/powerpc/c/c974809a26a13e40254dbe3c
I'd argue this is a bug fix and should hit stable too..
Cheers,
Ben.
prev parent reply other threads:[~2015-10-02 8:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 4:01 [PATCH v2 0/2] powerpc: powerpc/vdso: Avoid link stack corruption in __get_datapage() Michael Neuling
2015-09-25 4:01 ` [PATCH v2 1/2] powerpc/selftest: Add gettimeofday() benchmark Michael Neuling
2015-09-25 7:39 ` Arnd Bergmann
2015-09-25 9:28 ` Denis Kirjanov
2015-09-25 9:37 ` Gabriel Paubert
2015-09-25 12:47 ` Denis Kirjanov
2015-09-28 8:58 ` Michael Neuling
2015-09-28 9:56 ` Denis Kirjanov
2015-09-30 1:49 ` Michael Ellerman
2015-10-02 7:47 ` [v2,1/2] " Michael Ellerman
2015-09-25 4:01 ` [PATCH v2 2/2] powerpc/vdso: Avoid link stack corruption in __get_datapage() Michael Neuling
2015-10-02 7:47 ` [v2, " Michael Ellerman
2015-10-02 8:24 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443774290.27295.4.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=kda@linux-powerpc.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=sawdey@us.ibm.com \
--cc=sjmunroe@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).