From: Scott Wood <scottwood@freescale.com>
To: Zhiqiang Hou <B48286@freescale.com>
Cc: <linuxppc-dev@lists.ozlabs.org>, <galak@kernel.crashing.org>,
<benh@kernel.crashing.org>, <paulus@samba.org>,
<mpe@ellerman.id.au>, <devicetree@vger.kernel.org>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<harninder.rai@freescale.com>, <Minghuan.Lian@freescale.com>,
<Mingkai.Hu@freescale.com>
Subject: Re: [PATCH 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds
Date: Wed, 14 Oct 2015 15:36:08 -0500 [thread overview]
Message-ID: <1444854968.5185.205.camel@freescale.com> (raw)
In-Reply-To: <1444735761-1510-1-git-send-email-B48286@freescale.com>
On Tue, 2015-10-13 at 19:29 +0800, Zhiqiang Hou wrote:
> From: Harninder Rai <harninder.rai@freescale.com>
>
> Signed-off-by: Harninder Rai <harninder.rai@freescale.com>
> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> Change-Id: I4355add4a92d1fcf514843aea5ecadd2e2517969
> Reviewed-on: http://git.am.freescale.net:8181/2454
> Reviewed-by: Zang Tiefei-R61911 <tie-fei.zang@freescale.com>
> Reviewed-by: Kushwaha Prabhakar-B32579 <prabhakar@freescale.com>
> Reviewed-by: Fleming Andrew-AFLEMING <AFLEMING@freescale.com>
> Tested-by: Fleming Andrew-AFLEMING <AFLEMING@freescale.com>
Get rid of the gerrit stuff. And where is your signoff?
> diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> index c723071..78c8f1c 100644
> --- a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> @@ -40,6 +40,35 @@
> interrupts = <16 2 0 0 20 2 0 0>;
> };
>
> +/* controller at 0xa000 */
> +&pci0 {
> + compatible = "fsl,bsc9132-pcie", "fsl,qoriq-pcie-v2.2";
> + device_type = "pci";
> + #size-cells = <2>;
> + #address-cells = <3>;
> + bus-range = <0 255>;
> + clock-frequency = <33333333>;
> + interrupts = <16 2 0 0>;
This clock-frequency is not correct for PCIe. Just remove it.
-Scott
next prev parent reply other threads:[~2015-10-14 20:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 11:29 [PATCH 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds Zhiqiang Hou
2015-10-13 11:29 ` [PATCH 2/2] powerpc/85xx: Add PCIe controller support for bsc9132qds Zhiqiang Hou
2015-10-14 20:36 ` Scott Wood [this message]
2015-10-15 2:52 ` [PATCH 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds Hou Zhiqiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444854968.5185.205.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=B48286@freescale.com \
--cc=Minghuan.Lian@freescale.com \
--cc=Mingkai.Hu@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@kernel.crashing.org \
--cc=harninder.rai@freescale.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).