From: Michael Ellerman <mpe@ellerman.id.au>
To: Michal Marek <mmarek@suse.com>
Cc: linuxppc-dev@ozlabs.org, Olof Johannsson <olof@lixom.net>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
yann.morin.1998@free.fr
Subject: Re: [PATCH] scripts/kconfig/Makefile: Fix KBUILD_DEFCONFIG check when building with O=
Date: Thu, 15 Oct 2015 20:38:05 +1100 [thread overview]
Message-ID: <1444901885.8464.1.camel@ellerman.id.au> (raw)
In-Reply-To: <561F5552.4070902@suse.com>
On Thu, 2015-10-15 at 09:27 +0200, Michal Marek wrote:
> Dne 15.10.2015 v 08:05 Michael Ellerman napsal(a):
> > My recent commit d2036f30cfe1 ("scripts/kconfig/Makefile: Allow
> > KBUILD_DEFCONFIG to be a target"), contained a bug in that when it
> > checks if KBUILD_DEFCONFIG is a file it forgets to prepend $(srctree) to
> > the path.
> >
> > This causes the build to fail when building out of tree (with O=), and
> > when the value of KBUILD_DEFCONFIG is 'defconfig'. In that case we will
> > fail to find the 'defconfig' file, because we look in the build
> > directory not $(srctree), and so we will call Make again with
> > 'defconfig' as the target. From there we loop infinitely calling 'make
> > defconfig' again and again.
> >
> > The fix is simple, we need to look for the file under $(srctree).
> >
> > Fixes: d2036f30cfe1 ("scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target")
> > Reported-by: Olof Johansson <olof@lixom.net>
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Acked-by: Michal Marek <mmarek@suse.com>
>
> I could have spotted it myself :-/.
It was pretty easy to miss in the diff, especially as the kconfig invocation
doesn't use $(srctree).
I should have noticed it in my testing, but it didn't actually break powerpc,
so the only clue was that the message says "based on target". Anyway fixed now
hopefully.
cheers
prev parent reply other threads:[~2015-10-15 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 6:05 [PATCH] scripts/kconfig/Makefile: Fix KBUILD_DEFCONFIG check when building with O= Michael Ellerman
2015-10-15 7:27 ` Michal Marek
2015-10-15 9:38 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444901885.8464.1.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mmarek@suse.com \
--cc=olof@lixom.net \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).