From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0144.outbound.protection.outlook.com [65.55.169.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 7B75E1A0C04 for ; Sat, 24 Oct 2015 07:56:46 +1100 (AEDT) Message-ID: <1445633780.701.228.camel@freescale.com> Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common From: Scott Wood To: Zhao Qiang-B45475 CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xie Xiaobo-R63061 , "benh@kernel.crashing.org" , Li Yang-Leo-R58472 , "paulus@samba.org" Date: Fri, 23 Oct 2015 15:56:20 -0500 In-Reply-To: References: <1444806968-4627-1-git-send-email-qiang.zhao@freescale.com> <1444806968-4627-4-git-send-email-qiang.zhao@freescale.com> <1445569799.701.142.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2015-10-23 at 02:45 -0500, Zhao Qiang-B45475 wrote: > On Fri, 2015-10-23 at 11:10 AM, Wood Scott-B07421 > wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Friday, October 23, 2015 11:10 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > paulus@samba.org > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to > > qe_common > > > > On Wed, 2015-10-14 at 15:16 +0800, Zhao Qiang wrote: > > > QE and CPM have the same muram, they use the same management > > > functions. Now QE support both ARM and PowerPC, it is necessary to > > > move QE to "driver/soc", so move the muram management functions from > > > cpm_common to qe_common for preparing to move QE code to "driver/soc" > > > > > > Signed-off-by: Zhao Qiang > > > --- > > > Changes for v2: > > > - no changes > > > Changes for v3: > > > - no changes > > > Changes for v4: > > > - no changes > > > Changes for v5: > > > - no changes > > > Changes for v6: > > > - using genalloc instead rheap to manage QE MURAM > > > - remove qe_reset from platform file, using > > > - subsys_initcall to call qe_init function. > > > Changes for v7: > > > - move this patch from 3/3 to 2/3 > > > - convert cpm with genalloc > > > - check for gen_pool allocation failure Changes for v8: > > > - rebase > > > - move BD_SC_* macro instead of copy Changes for v9: > > > - doesn't modify CPM, add a new patch to modify. > > > - rebase > > > Changes for v10: > > > - rebase > > > Changes for v11: > > > - remove renaming > > > - delete removing qe_reset and delete adding qe_init. > > > Changes for v12: > > > - SPI_FSL_CPM depends on QE-MURAM, select QUICC_ENGINE for it. > > > > Why is the SPI change part of this patch? Why is it even part of this > > patchset, > > rather than an independent patch sent to the SPI list and maintainer? If > > it's tied > > to other changes you're making, explain that. As is, there is zero > > mention of > > the SPI change in the part of the e-mail that will become the git > > changelog. > > > This SPI_FSL_CPM is cpm-spi, it is part of CPM. So then why are you selecting QUICC_ENGINE? And again, what does it have to do with this patch? -Scott