From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.transmode.se (smtp.transmode.se [31.15.61.139]) by lists.ozlabs.org (Postfix) with ESMTP id C37541A0B5F for ; Tue, 3 Nov 2015 22:23:21 +1100 (AEDT) From: Joakim Tjernlund To: "netdev@vger.kernel.org" , "madalin.bucur@freescale.com" CC: "scottwood@freescale.com" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "ppc@mindchasers.com" , "roy.pledge@freescale.com" , "Igal.Liberman@freescale.com" , "pebolle@tiscali.nl" , "joe@perches.com" , "davem@davemloft.net" Subject: Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Date: Tue, 3 Nov 2015 11:23:14 +0000 Message-ID: <1446549794.21216.56.camel@transmode.se> References: <1446485500-9782-1-git-send-email-madalin.bucur@freescale.com> <1446485500-9782-3-git-send-email-madalin.bucur@freescale.com> <1446537357.21216.49.camel@transmode.se> In-Reply-To: Content-Type: text/plain; charset="iso-8859-15" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2015-11-03 at 09:37 +0000, Madalin-Cristian Bucur wrote: > > -----Original Message----- > > From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se] > >=20 > > On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > > > + if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) !=3D 0) { > > > + if (net_ratelimit()) > > > + netif_warn(priv, hw, net_dev, "FD status =3D > > 0x%08x\n", > > > + fd_status & FM_FD_STAT_RX_ERRORS); > > > + > > > + percpu_stats->rx_errors++; > > > + goto _release_frame; > > > + } > >=20 > > I cannot find any detailed error accounting(maybe I am not looking hard > > enough) but I > > would appreciate if both TX and RX errors where better > > accounted(rx_length_errors, rx_frame_errors, > > rx_crc_errors, rx_fifo_errors etc.). This has helped me many times in t= he > > past diagnosing > > board HW problems. > >=20 > > Jocke >=20 > Hi Jocke, >=20 > There are some error counters exported through ethtool (used to be debugf= s). > FMan HW provides more debug information than we currently export, that wi= ll be > improved in the future but given the current priority of having a codebas= e as > small and reviewable as possible we had to drop some things from the init= ial > submission. I know, but ethtool is not always available. Even the old fec_main.c has it: if (status & (BD_ENET_RX_LG | BD_ENET_RX_SH | BD_ENET_RX_NO | BD_ENET_RX_CR | BD_ENET_RX_OV)) { ndev->stats.rx_errors++; if (status & (BD_ENET_RX_LG | BD_ENET_RX_SH)) { /* Frame too long or too short. */ ndev->stats.rx_length_errors++; } if (status & BD_ENET_RX_NO) /* Frame alignment */ ndev->stats.rx_frame_errors++; if (status & BD_ENET_RX_CR) /* CRC Error */ ndev->stats.rx_crc_errors++; if (status & BD_ENET_RX_OV) /* FIFO overrun */ ndev->stats.rx_fifo_errors++; } so it is just a few more lines ... Pretty please ? :) Jocke