From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: gwshan@linux.vnet.ibm.com, bhelgaas@google.com,
mpe@ellerman.id.au, aik@ozlabs.ru
Cc: linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
Wei Yang <weiyang@linux.vnet.ibm.com>
Subject: [PATCH V13 4/9] powerpc/eeh: Cache only BARs, not windows or IOV BARs
Date: Sun, 8 Nov 2015 07:30:30 +0800 [thread overview]
Message-ID: <1446939035-2617-5-git-send-email-weiyang@linux.vnet.ibm.com> (raw)
In-Reply-To: <1446939035-2617-1-git-send-email-weiyang@linux.vnet.ibm.com>
This restricts the EEH address cache to use only the first 7 BARs. This
makes __eeh_addr_cache_insert_dev() ignore PCI bridge window and IOV BARs.
As the result of this change, eeh_addr_cache_get_dev() will return VFs from
VF's resource addresses instead of parent PFs.
This removes extra check for a PCI bridge as we limit
__eeh_addr_cache_insert_dev() to 7 BARs and this effectively excludes PCI
bridges from being cached.
Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
---
arch/powerpc/kernel/eeh_cache.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/kernel/eeh_cache.c b/arch/powerpc/kernel/eeh_cache.c
index a1e86e1..ddbcfab 100644
--- a/arch/powerpc/kernel/eeh_cache.c
+++ b/arch/powerpc/kernel/eeh_cache.c
@@ -195,8 +195,11 @@ static void __eeh_addr_cache_insert_dev(struct pci_dev *dev)
return;
}
- /* Walk resources on this device, poke them into the tree */
- for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
+ /*
+ * Walk resources on this device, poke the first 7 (6 normal BAR and 1
+ * ROM BAR) into the tree.
+ */
+ for (i = 0; i <= PCI_ROM_RESOURCE; i++) {
resource_size_t start = pci_resource_start(dev,i);
resource_size_t end = pci_resource_end(dev,i);
unsigned long flags = pci_resource_flags(dev,i);
@@ -222,10 +225,6 @@ void eeh_addr_cache_insert_dev(struct pci_dev *dev)
{
unsigned long flags;
- /* Ignore PCI bridges */
- if ((dev->class >> 16) == PCI_BASE_CLASS_BRIDGE)
- return;
-
spin_lock_irqsave(&pci_io_addr_cache_root.piar_lock, flags);
__eeh_addr_cache_insert_dev(dev);
spin_unlock_irqrestore(&pci_io_addr_cache_root.piar_lock, flags);
--
2.5.0
next prev parent reply other threads:[~2015-11-07 23:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 23:30 [PATCH V13 0/9] VF EEH on Power8 Wei Yang
2015-11-07 23:30 ` [PATCH V13 1/9] PCI/IOV: Rename and export virtfn_add/virtfn_remove Wei Yang
2015-11-07 23:30 ` [PATCH V13 2/9] PCI: Add pcibios_bus_add_device() weak function Wei Yang
2015-11-07 23:30 ` [PATCH V13 3/9] powerpc/pci: Remove VFs prior to PF Wei Yang
2015-11-07 23:30 ` Wei Yang [this message]
2015-11-07 23:30 ` [PATCH V13 5/9] powerpc/powernv: EEH device for VF Wei Yang
2015-11-07 23:30 ` [PATCH V13 6/9] powerpc/eeh: Create PE for VFs Wei Yang
2015-11-07 23:30 ` [PATCH V13 7/9] powerpc/powernv: Support EEH reset for VF PE Wei Yang
2015-11-07 23:30 ` [PATCH V13 8/9] powerpc/powernv: Support PCI config restore for VFs Wei Yang
2015-11-07 23:30 ` [PATCH V13 9/9] powerpc/eeh: Support error recovery for VF PE Wei Yang
2015-11-19 11:46 ` [V13,9/9] " Michael Ellerman
2015-11-08 23:53 ` [PATCH V13 0/9] VF EEH on Power8 Alexey Kardashevskiy
2015-11-09 1:53 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446939035-2617-5-git-send-email-weiyang@linux.vnet.ibm.com \
--to=weiyang@linux.vnet.ibm.com \
--cc=aik@ozlabs.ru \
--cc=bhelgaas@google.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).