From: Michael Ellerman <mpe@ellerman.id.au>
To: robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, mitchelh@codeaurora.org,
frowand.list@gmail.com, grant.likely@linaro.org
Subject: Re: [PATCH] of: Print rather than WARN'ing when overlap check fails
Date: Tue, 10 Nov 2015 20:28:55 +1100 [thread overview]
Message-ID: <1447147735.1314.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1447132113-31434-1-git-send-email-mpe@ellerman.id.au>
On Tue, 2015-11-10 at 16:08 +1100, Michael Ellerman wrote:
> __rmem_check_for_overlap() is called very early in boot, and on some
> powerpc systems it's not safe to call WARN that early in boot.
>
> If the overlap check fails the system will oops instead of printing a
> warning. Furthermore because it's so early in boot the console is not up
> and the user doesn't see the oops, they just get a dead system.
>
> Fix it by printing an error instead of calling WARN.
>
> Fixes: ae1add247bf8 ("of: Check for overlap in reserved memory regions")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> drivers/of/of_reserved_mem.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
I forgot to say, I assume you're OK to merge this and get it to Linus soonish?
Otherwise I can stuff it in a fix branch and ask Linus to pull that. Let me
know which you'd prefer.
cheers
next prev parent reply other threads:[~2015-11-10 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 5:08 [PATCH] of: Print rather than WARN'ing when overlap check fails Michael Ellerman
2015-11-10 9:28 ` Michael Ellerman [this message]
2015-11-10 9:41 ` David Laight
2015-11-10 21:47 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447147735.1314.1.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mitchelh@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).