From: Michael Ellerman <mpe@ellerman.id.au>
To: David Laight <David.Laight@ACULAB.COM>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"frowand.list@gmail.com" <frowand.list@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"mitchelh@codeaurora.org" <mitchelh@codeaurora.org>
Subject: Re: [PATCH] of: Print rather than WARN'ing when overlap check fails
Date: Wed, 11 Nov 2015 08:47:03 +1100 [thread overview]
Message-ID: <1447192023.25407.0.camel@ellerman.id.au> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CBCEE2E@AcuExch.aculab.com>
On Tue, 2015-11-10 at 09:41 +0000, David Laight wrote:
> From: Michael Ellerman
> > Sent: 10 November 2015 05:09
> > __rmem_check_for_overlap() is called very early in boot, and on some
> > powerpc systems it's not safe to call WARN that early in boot.
> >
> > If the overlap check fails the system will oops instead of printing a
> > warning. Furthermore because it's so early in boot the console is not up
> > and the user doesn't see the oops, they just get a dead system.
>
> Wouldn't it be better to add the required checks to WARN()?
Yes obviously it would. But that's less simple than it sounds. I'm working on
it.
cheers
prev parent reply other threads:[~2015-11-10 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 5:08 [PATCH] of: Print rather than WARN'ing when overlap check fails Michael Ellerman
2015-11-10 9:28 ` Michael Ellerman
2015-11-10 9:41 ` David Laight
2015-11-10 21:47 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447192023.25407.0.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=David.Laight@ACULAB.COM \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mitchelh@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).