linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Denis Kirjanov <kda@linux-powerpc.org>
Cc: linuxppc-dev@ozlabs.org,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	 Anton Blanchard <anton@samba.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: tracing: don't trace hcalls on offline CPUs
Date: Mon, 23 Nov 2015 10:35:59 +1100	[thread overview]
Message-ID: <1448235359.18775.1.camel@ellerman.id.au> (raw)
In-Reply-To: <CAOJe8K1q=bO5iKfnG=9ZLNvk0sREcfqNJuHNhyspe6MG4hSfHA@mail.gmail.com>

On Fri, 2015-11-20 at 15:22 +0300, Denis Kirjanov wrote:
> On 11/3/15, Denis Kirjanov <kda@linux-powerpc.org> wrote:
> > On 11/3/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
> > > On Thu, 2015-10-29 at 22:10 +0300, Denis Kirjanov wrote:
> > > > ./drmgr -c cpu -a -r gives the following warning:
> > > > 
> > > > [ 2327.035563] RCU used illegally from offline CPU!
> > > > 
> > > > Make the hypervisor tracepoints conditional by introducing
> > > > TRACE_EVENT_FN_COND similar to TRACE_EVENT_FN
> > > 
> > > We've fixed other cases like this with RCU_NONIDLE(), but I assume that
> > > doesn't work here because we're actually offline?
> > 
> > Yes, in this case we're moving the complete core offline through dlpar...
> > 
> 
> Hi Michael,
> Could you pick this patch?

It's mostly a tracing patch, so I'd need an ACK from Steve at least.

It would probably be best if you split it into a "tracing: .. " patch which
adds the new macros and then a powerpc patch which uses them.

cheers

  reply	other threads:[~2015-11-22 23:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 19:10 [PATCH] powerpc: tracing: don't trace hcalls on offline CPUs Denis Kirjanov
2015-11-03 10:06 ` Michael Ellerman
2015-11-03 12:58   ` Denis Kirjanov
2015-11-20 12:22     ` Denis Kirjanov
2015-11-22 23:35       ` Michael Ellerman [this message]
2015-11-23  0:52         ` Steven Rostedt
2015-11-23  9:31         ` Denis Kirjanov
2015-11-03 13:25   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448235359.18775.1.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=anton@samba.org \
    --cc=kda@linux-powerpc.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).