linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Martin Roth <martin.roth@motorolasolutions.com>
To: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] fs_enet: Adjust BDs after tx error
Date: Tue, 24 Nov 2015 00:08:54 -0700 (MST)	[thread overview]
Message-ID: <1448348934144-101274.post@n7.nabble.com> (raw)
In-Reply-To: <4BFDC6EC.9090804@elphinstone.net>

Hi,

I have reviewed the code and in my opinion the  line 

                     last_tx_bd = fep->tx_bd_base + (fpi->tx_ring *
sizeof(cbd_t)); 

should be replaced with
              
                     last_tx_bd = fep->tx_bd_base + ((fpi->tx_ring-1) *
sizeof(cbd_t));  

In  the original code  the last_tx_bd  points to location after the last
base descriptor end.
In the code fix that I propose, the  last_tx_bd points to the last
descriptor.  

Am I missing something ?

Thanks,
Martin  



--
View this message in context: http://linuxppc.10917.n7.nabble.com/PATCH-fs-enet-Adjust-BDs-after-tx-error-tp37529p101274.html
Sent from the linuxppc-dev mailing list archive at Nabble.com.

      parent reply	other threads:[~2015-11-24  7:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27  1:12 [PATCH] fs_enet: Adjust BDs after tx error Mark Ware
2010-05-29  7:16 ` David Miller
2015-11-24  7:08 ` Martin Roth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448348934144-101274.post@n7.nabble.com \
    --to=martin.roth@motorolasolutions.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).