From: Martin Roth <martin.roth@motorolasolutions.com>
To: linuxppc-dev@ozlabs.org
Subject: FCC driver for Motorola MPC82xx - an error found
Date: Tue, 24 Nov 2015 05:19:51 -0700 (MST) [thread overview]
Message-ID: <1448367591225-101297.post@n7.nabble.com> (raw)
I was looking for an error on MPC8270 processor 100 Mbps Ethernet FCC port.
The port may become locked if it is set to AUTO, while the peer is forced to
100 Mbs full duplex (non AUTO).
I was looking for an error in the area of collision handling of the driver.
It looks like I found the problem.
The error is at line 555:
http://lxr.free-electrons.com/source/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c#L555
The problem is that the last descriptor address is not calculated correctly.
Instead of
last_tx_bd = fep->tx_bd_base + (fpi->tx_ring * sizeof(cbd_t));
The fix should be:
last_tx_bd = fep->tx_bd_base + ((fpi->tx_ring-1)* sizeof(cbd_t));
Is it a bug?
Thanks,
Martin Roth
--
View this message in context: http://linuxppc.10917.n7.nabble.com/FCC-driver-for-Motorola-MPC82xx-an-error-found-tp101297.html
Sent from the linuxppc-dev mailing list archive at Nabble.com.
next reply other threads:[~2015-11-24 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 12:19 Martin Roth [this message]
2015-12-08 1:29 ` FCC driver for Motorola MPC82xx - an error found Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448367591225-101297.post@n7.nabble.com \
--to=martin.roth@motorolasolutions.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).