linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: Append linux_banner to exception information in xmon.
@ 2015-11-24 23:37 Rashmica Gupta
  2015-11-25  2:35 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Rashmica Gupta @ 2015-11-24 23:37 UTC (permalink / raw)
  To: linuxppc-dev

Currently if you are in xmon without an oops etc. to view the kernel version you have to type "d $linux_banner" - not necessarily obvious. As this is useful information, append to the output of "e" command.

Signed-off-by: Rashmica Gupta <rashmicy@gmail.com>
---
 arch/powerpc/xmon/xmon.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index df05bd2fca07..6d3d9d031aea 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1528,6 +1528,8 @@ static void excprint(struct pt_regs *fp)
 
 	if (trap == 0x700)
 		print_bug_trap(fp);
+
+	printf(linux_banner);
 }
 
 static void prregs(struct pt_regs *fp)
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc: Append linux_banner to exception information in xmon.
  2015-11-24 23:37 [PATCH] powerpc: Append linux_banner to exception information in xmon Rashmica Gupta
@ 2015-11-25  2:35 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2015-11-25  2:35 UTC (permalink / raw)
  To: Rashmica Gupta, linuxppc-dev

Hi Rashmica,

Can you make your subject "powerpc/xmon: ...".

On Wed, 2015-11-25 at 10:37 +1100, Rashmica Gupta wrote:

> Currently if you are in xmon without an oops etc. to view the kernel version you have to type "d $linux_banner" - not necessarily obvious. As this is useful information, append to the output of "e"
> command.

This line should be word wrapped.

And can you include an example of the output in the change log?

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-25  2:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-24 23:37 [PATCH] powerpc: Append linux_banner to exception information in xmon Rashmica Gupta
2015-11-25  2:35 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).