From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 9467F1A0286 for ; Wed, 2 Dec 2015 09:18:05 +1100 (AEDT) Message-ID: <1449008285.12022.0.camel@ellerman.id.au> Subject: Re: [PATCH v4 2/9] ppc64le FTRACE_WITH_REGS implementation From: Michael Ellerman To: Torsten Duwe , Denis Kirjanov Cc: Steven Rostedt , Jiri Kosina , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Date: Wed, 02 Dec 2015 09:18:05 +1100 In-Reply-To: <20151201172914.GB5509@lst.de> References: <20151125172608.9588569260@newverein.lst.de> <20151125172902.82C6C69260@newverein.lst.de> <20151201172914.GB5509@lst.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2015-12-01 at 18:29 +0100, Torsten Duwe wrote: > On Thu, Nov 26, 2015 at 01:04:19PM +0300, Denis Kirjanov wrote: > > > diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S > > > index 8d56b16..3309dd8 100644 > > > --- a/arch/powerpc/kernel/entry_64.S > > > +++ b/arch/powerpc/kernel/entry_64.S > > Linux style for comments is the C89. Please update entry_64.S > > Any other (planned) remarks or comments on the patch set? > If not I'll make a 5th, hopefully final version. I (still) haven't had a chance to have a good look at it, but I won't this week anyway. So post v5 and hopefully I can review that and it will be perfect :) cheers