* [PATCH] kvm: remove unused variable 'vcpu_book3s'
@ 2015-12-01 23:42 Geyslan G. Bem
2015-12-02 0:34 ` Daniel Axtens
2015-12-10 0:39 ` Paul Mackerras
0 siblings, 2 replies; 4+ messages in thread
From: Geyslan G. Bem @ 2015-12-01 23:42 UTC (permalink / raw)
Cc: Geyslan G. Bem, Alexander Graf, Gleb Natapov, Paolo Bonzini,
Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman, kvm-ppc,
kvm, linuxppc-dev, linux-kernel
The vcpu_book3s struct is assigned but never used. So remove it.
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
arch/powerpc/kvm/book3s_64_mmu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
index 774a253..9bf7031 100644
--- a/arch/powerpc/kvm/book3s_64_mmu.c
+++ b/arch/powerpc/kvm/book3s_64_mmu.c
@@ -377,15 +377,12 @@ no_seg_found:
static void kvmppc_mmu_book3s_64_slbmte(struct kvm_vcpu *vcpu, u64 rs, u64 rb)
{
- struct kvmppc_vcpu_book3s *vcpu_book3s;
u64 esid, esid_1t;
int slb_nr;
struct kvmppc_slb *slbe;
dprintk("KVM MMU: slbmte(0x%llx, 0x%llx)\n", rs, rb);
- vcpu_book3s = to_book3s(vcpu);
-
esid = GET_ESID(rb);
esid_1t = GET_ESID_1T(rb);
slb_nr = rb & 0xfff;
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] kvm: remove unused variable 'vcpu_book3s'
2015-12-01 23:42 [PATCH] kvm: remove unused variable 'vcpu_book3s' Geyslan G. Bem
@ 2015-12-02 0:34 ` Daniel Axtens
2015-12-02 1:11 ` Geyslan G. Bem
2015-12-10 0:39 ` Paul Mackerras
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Axtens @ 2015-12-02 0:34 UTC (permalink / raw)
To: Geyslan G. Bem
Cc: Geyslan G. Bem, kvm, Gleb Natapov, linux-kernel, kvm-ppc,
Paul Mackerras, Paolo Bonzini, linuxppc-dev, Alexander Graf
[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]
"Geyslan G. Bem" <geyslan@gmail.com> writes:
> The vcpu_book3s struct is assigned but never used. So remove it.
Just out of interest, how did you find this? Compiler warning? Static
analysis? Manual inspection?
Thanks in advance!
Regards,
Daniel
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
> arch/powerpc/kvm/book3s_64_mmu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
> index 774a253..9bf7031 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu.c
> @@ -377,15 +377,12 @@ no_seg_found:
>
> static void kvmppc_mmu_book3s_64_slbmte(struct kvm_vcpu *vcpu, u64 rs, u64 rb)
> {
> - struct kvmppc_vcpu_book3s *vcpu_book3s;
> u64 esid, esid_1t;
> int slb_nr;
> struct kvmppc_slb *slbe;
>
> dprintk("KVM MMU: slbmte(0x%llx, 0x%llx)\n", rs, rb);
>
> - vcpu_book3s = to_book3s(vcpu);
> -
> esid = GET_ESID(rb);
> esid_1t = GET_ESID_1T(rb);
> slb_nr = rb & 0xfff;
> --
> 2.6.2
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 859 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kvm: remove unused variable 'vcpu_book3s'
2015-12-02 0:34 ` Daniel Axtens
@ 2015-12-02 1:11 ` Geyslan G. Bem
0 siblings, 0 replies; 4+ messages in thread
From: Geyslan G. Bem @ 2015-12-02 1:11 UTC (permalink / raw)
To: Daniel Axtens
Cc: kvm, Gleb Natapov, LKML, kvm-ppc, Paul Mackerras, Paolo Bonzini,
linuxppc-dev, Alexander Graf
2015-12-01 21:34 GMT-03:00 Daniel Axtens <dja@axtens.net>:
> "Geyslan G. Bem" <geyslan@gmail.com> writes:
>
>> The vcpu_book3s struct is assigned but never used. So remove it.
>
> Just out of interest, how did you find this? Compiler warning? Static
> analysis? Manual inspection?
Sorry, I should have done the patch self contained. I caught it
through static analysis (cppcheck).
>
> Thanks in advance!
You're welcome.
>
> Regards,
> Daniel
>
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>> ---
>> arch/powerpc/kvm/book3s_64_mmu.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
>> index 774a253..9bf7031 100644
>> --- a/arch/powerpc/kvm/book3s_64_mmu.c
>> +++ b/arch/powerpc/kvm/book3s_64_mmu.c
>> @@ -377,15 +377,12 @@ no_seg_found:
>>
>> static void kvmppc_mmu_book3s_64_slbmte(struct kvm_vcpu *vcpu, u64 rs, u64 rb)
>> {
>> - struct kvmppc_vcpu_book3s *vcpu_book3s;
>> u64 esid, esid_1t;
>> int slb_nr;
>> struct kvmppc_slb *slbe;
>>
>> dprintk("KVM MMU: slbmte(0x%llx, 0x%llx)\n", rs, rb);
>>
>> - vcpu_book3s = to_book3s(vcpu);
>> -
>> esid = GET_ESID(rb);
>> esid_1t = GET_ESID_1T(rb);
>> slb_nr = rb & 0xfff;
>> --
>> 2.6.2
>>
>> _______________________________________________
>> Linuxppc-dev mailing list
>> Linuxppc-dev@lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/linuxppc-dev
--
Regards,
Geyslan G. Bem
hackingbits.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kvm: remove unused variable 'vcpu_book3s'
2015-12-01 23:42 [PATCH] kvm: remove unused variable 'vcpu_book3s' Geyslan G. Bem
2015-12-02 0:34 ` Daniel Axtens
@ 2015-12-10 0:39 ` Paul Mackerras
1 sibling, 0 replies; 4+ messages in thread
From: Paul Mackerras @ 2015-12-10 0:39 UTC (permalink / raw)
To: Geyslan G. Bem; +Cc: Alexander Graf, kvm-ppc, kvm, linuxppc-dev, linux-kernel
On Tue, Dec 01, 2015 at 08:42:10PM -0300, Geyslan G. Bem wrote:
> The vcpu_book3s struct is assigned but never used. So remove it.
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
Thanks, applied to my kvm-ppc-next branch.
Paul.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-10 0:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-01 23:42 [PATCH] kvm: remove unused variable 'vcpu_book3s' Geyslan G. Bem
2015-12-02 0:34 ` Daniel Axtens
2015-12-02 1:11 ` Geyslan G. Bem
2015-12-10 0:39 ` Paul Mackerras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).