From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id BBDFB1A0EE1 for ; Tue, 8 Dec 2015 15:00:37 +1100 (AEDT) From: Paul Gortmaker To: CC: Paul Gortmaker , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Subject: [PATCH] powerpc: warn on spurious irq events (but ratelimited) Date: Mon, 7 Dec 2015 20:38:27 -0500 Message-ID: <1449538707-7867-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , It might be worth warning on spurious IRQ events; they might point someone at a bogus DTS value or similar. But ratelimit them to ensure we aren't too spammy about it. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Paul Gortmaker --- arch/powerpc/kernel/irq.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c index 290559df1e8b..5c777e3a4c04 100644 --- a/arch/powerpc/kernel/irq.c +++ b/arch/powerpc/kernel/irq.c @@ -497,10 +497,12 @@ void __do_irq(struct pt_regs *regs) may_hard_irq_enable(); /* And finally process it */ - if (unlikely(irq == NO_IRQ)) + if (unlikely(irq == NO_IRQ)) { + printk_ratelimited(KERN_WARNING "spurious irq on %d\n", irq); __this_cpu_inc(irq_stat.spurious_irqs); - else + } else { generic_handle_irq(irq); + } trace_irq_exit(regs); -- 2.6.1