From: Scott Wood <scottwood@freescale.com>
To: Andy Fleming <afleming@gmail.com>, <igal.liberman@freescale.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<madalin.bucur@freescale.com>, <pebolle@tiscali.nl>,
Joakim Tjernlund <joakim.tjernlund@transmode.se>,
<ppc@mindchasers.com>, <stephen@networkplumber.org>,
David Miller <davem@davemloft.net>
Subject: Re: [v9, 6/6] fsl/fman: Add FMan MAC driver
Date: Tue, 8 Dec 2015 16:44:38 -0600 [thread overview]
Message-ID: <1449614678.15946.152.camel@freescale.com> (raw)
In-Reply-To: <CAKWjMd7EDx8OnYGu-QJXM++fy=W5i2E74Fe4r9zNjUV_giyUKw@mail.gmail.com>
On Tue, 2015-12-08 at 14:18 -0600, Andy Fleming wrote:
> On Thu, Dec 3, 2015 at 1:19 AM, <igal.liberman@freescale.com> wrote:
> > From: Igal Liberman <igal.liberman@freescale.com>
> >
> > This patch adds the Ethernet MAC driver supporting the three
> > different types of MACs: dTSEC, tGEC and mEMAC.
> >
> > Signed-off-by: Igal Liberman <igal.liberman@freescale.com>
>
> [...]
>
> > +
> > +MODULE_LICENSE("Dual BSD/GPL");
> > +
> > +MODULE_AUTHOR("Emil Medve <Emilian.Medve@Freescale.com>");
>
> I imagine this email address doesn't exist anymore, or won't soon.
> This is also an issue in the ethernet driver (with my old address).
> I'm not sure what the right approach is, but we shouldn't be putting
> obsolete email addresses in the kernel.
I don't think a MODULE_AUTHOR tag makes sense for drivers like this that had a
lot of people work on them. git history is better for giving credit in such
cases.
-Scott
next prev parent reply other threads:[~2015-12-08 22:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 7:19 [v9, 0/6] Freescale DPAA FMan igal.liberman
2015-12-03 7:19 ` [v9, 1/6] fsl/fman: Add FMan MURAM support igal.liberman
2015-12-03 7:19 ` [v9, 2/6] fsl/fman: Add FMan support igal.liberman
2015-12-03 7:19 ` [v9, 3/6] fsl/fman: Add FMan MAC support igal.liberman
2015-12-03 20:23 ` David Miller
2015-12-08 11:20 ` Liberman Igal
2015-12-03 22:42 ` Kenneth Klette Jonassen
2015-12-03 7:19 ` [v9, 4/6] fsl/fman: Add FMan SP support igal.liberman
2015-12-03 7:19 ` [v9, 5/6] fsl/fman: Add FMan Port Support igal.liberman
2015-12-03 7:19 ` [v9, 6/6] fsl/fman: Add FMan MAC driver igal.liberman
2015-12-08 20:18 ` Andy Fleming
2015-12-08 22:44 ` Scott Wood [this message]
2015-12-09 2:17 ` David Miller
2015-12-09 10:10 ` Madalin-Cristian Bucur
2015-12-09 17:07 ` Scott Wood
2015-12-15 11:55 ` Liberman Igal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449614678.15946.152.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=afleming@gmail.com \
--cc=davem@davemloft.net \
--cc=igal.liberman@freescale.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=ppc@mindchasers.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).