linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Michael Neuling <mikey@neuling.org>,
	Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	linuxppc-dev@ozlabs.org
Cc: imunsie@au1.ibm.com, dja@axtens.net,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] cxl: sparse: add __iomem annotations in vphb.c
Date: Wed, 09 Dec 2015 12:06:51 +1100	[thread overview]
Message-ID: <1449623211.6028.10.camel@ellerman.id.au> (raw)
In-Reply-To: <1449622825.8861.4.camel@neuling.org>

On Wed, 2015-12-09 at 12:00 +1100, Michael Neuling wrote:
> On Tue, 2015-12-08 at 17:30 +1100, Andrew Donnellan wrote:
> > Finally looking at this patch again for the first time in a couple of
> > months...
> > 
> > On 04/11/15 17:17, Andrew Donnellan wrote:
> > > On 03/11/15 20:09, Michael Ellerman wrote:
> > > > Part of your problem is you're storing afu->crs_len which is not __iomem in
> > > > cfg_data which is, and so that's leading to some of your casts.
> > > > 
> > > > I don't really see why you're using cfg_data like that, you have the
> > > > afu in phb->private_data. But maybe cfg_data needs to hold that value
> > > > for some other code I'm not seeing.
> > > 
> > > I can't see any obvious reason why we need to use cfg_data either.
> > 
> > Ian/Mikey - do you happen to know why we're using cfg_data? I've
> > taken another look and I can't see anything obvious.
> 
> IIRC, when I coded this up, benh just said these (cfg_addr/data) are
> just private data and we can stick whatever we like in there.
> 
> We could store it in the AFU struct but it's (was just) convenient to
> just store it here.

You're storing afu->crs_len in there, so it is in the AFU struct. Unless
there's a different "AFU struct", in which case meh.

Please send me a patch to clean it up Andrew.

cheers

      reply	other threads:[~2015-12-09  1:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28  3:29 [PATCH] cxl: sparse: add __iomem annotations in vphb.c Andrew Donnellan
2015-10-28  3:49 ` Ian Munsie
2015-10-30 13:07 ` Arnd Bergmann
2015-11-02  4:57   ` Andrew Donnellan
2015-11-03  9:09 ` Michael Ellerman
2015-11-04  6:17   ` Andrew Donnellan
2015-12-08  6:30     ` Andrew Donnellan
2015-12-09  1:00       ` Michael Neuling
2015-12-09  1:06         ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449623211.6028.10.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=dja@axtens.net \
    --cc=imunsie@au1.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mikey@neuling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).