From: Michael Ellerman <mpe@ellerman.id.au>
To: Russell Currey <ruscur@russell.cc>,
Daniel Axtens <dja@axtens.net>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: add va_end()
Date: Thu, 17 Dec 2015 23:24:37 +1100 [thread overview]
Message-ID: <1450355077.8262.0.camel@ellerman.id.au> (raw)
In-Reply-To: <1450354171.1669.4.camel@russell.cc>
On Thu, 2015-12-17 at 23:09 +1100, Russell Currey wrote:
> On Thu, 2015-12-17 at 19:41 +1100, Daniel Axtens wrote:
> > cppcheck picked up that there were a couple of missing va_end()
> > calls in functions using va_start().
> >
> > Signed-off-by: Daniel Axtens <dja@axtens.net>
> Hey Daniel,
>
> It's probably not worth a V2 but I think this could use a commit title that's a
> bit more detailed. Right now it doesn't really allude to what it fixes or what
> it affects.
Yeah, the change log is OK, but the actual subject is a bit terse.
I changed it to "powerpc: Add missing calls to va_end()".
cheers
next prev parent reply other threads:[~2015-12-17 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 8:41 [PATCH] powerpc: add va_end() Daniel Axtens
2015-12-17 12:09 ` Russell Currey
2015-12-17 12:24 ` Michael Ellerman [this message]
2015-12-18 1:58 ` Daniel Axtens
2016-01-11 9:14 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450355077.8262.0.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=dja@axtens.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).