* [PATCH] powerpc: add va_end()
@ 2015-12-17 8:41 Daniel Axtens
2015-12-17 12:09 ` Russell Currey
2016-01-11 9:14 ` Michael Ellerman
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Axtens @ 2015-12-17 8:41 UTC (permalink / raw)
To: linuxppc-dev; +Cc: mpe, Daniel Axtens
cppcheck picked up that there were a couple of missing va_end()
calls in functions using va_start().
Signed-off-by: Daniel Axtens <dja@axtens.net>
---
arch/powerpc/kernel/prom_init.c | 1 +
arch/powerpc/platforms/powermac/bootx_init.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 92dea8df6b26..da5192590c44 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -389,6 +389,7 @@ static void __init prom_printf(const char *format, ...)
break;
}
}
+ va_end(args);
}
diff --git a/arch/powerpc/platforms/powermac/bootx_init.c b/arch/powerpc/platforms/powermac/bootx_init.c
index 76f5013c35e5..c3c9bbb3573a 100644
--- a/arch/powerpc/platforms/powermac/bootx_init.c
+++ b/arch/powerpc/platforms/powermac/bootx_init.c
@@ -84,6 +84,7 @@ static void __init bootx_printf(const char *format, ...)
break;
}
}
+ va_end(args);
}
#else /* CONFIG_BOOTX_TEXT */
static void __init bootx_printf(const char *format, ...) {}
--
2.6.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc: add va_end()
2015-12-17 8:41 [PATCH] powerpc: add va_end() Daniel Axtens
@ 2015-12-17 12:09 ` Russell Currey
2015-12-17 12:24 ` Michael Ellerman
2016-01-11 9:14 ` Michael Ellerman
1 sibling, 1 reply; 5+ messages in thread
From: Russell Currey @ 2015-12-17 12:09 UTC (permalink / raw)
To: Daniel Axtens, linuxppc-dev
On Thu, 2015-12-17 at 19:41 +1100, Daniel Axtens wrote:
> cppcheck picked up that there were a couple of missing va_end()
> calls in functions using va_start().
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
Hey Daniel,
It's probably not worth a V2 but I think this could use a commit title that's a
bit more detailed. Right now it doesn't really allude to what it fixes or what
it affects.
Reviewed-by: Russell Currey <ruscur@russell.cc>
> ---
> arch/powerpc/kernel/prom_init.c | 1 +
> arch/powerpc/platforms/powermac/bootx_init.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/kernel/prom_init.c
> b/arch/powerpc/kernel/prom_init.c
> index 92dea8df6b26..da5192590c44 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -389,6 +389,7 @@ static void __init prom_printf(const char *format, ...)
> break;
> }
> }
> + va_end(args);
> }
>
>
> diff --git a/arch/powerpc/platforms/powermac/bootx_init.c
> b/arch/powerpc/platforms/powermac/bootx_init.c
> index 76f5013c35e5..c3c9bbb3573a 100644
> --- a/arch/powerpc/platforms/powermac/bootx_init.c
> +++ b/arch/powerpc/platforms/powermac/bootx_init.c
> @@ -84,6 +84,7 @@ static void __init bootx_printf(const char *format, ...)
> break;
> }
> }
> + va_end(args);
> }
> #else /* CONFIG_BOOTX_TEXT */
> static void __init bootx_printf(const char *format, ...) {}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc: add va_end()
2015-12-17 12:09 ` Russell Currey
@ 2015-12-17 12:24 ` Michael Ellerman
2015-12-18 1:58 ` Daniel Axtens
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2015-12-17 12:24 UTC (permalink / raw)
To: Russell Currey, Daniel Axtens, linuxppc-dev
On Thu, 2015-12-17 at 23:09 +1100, Russell Currey wrote:
> On Thu, 2015-12-17 at 19:41 +1100, Daniel Axtens wrote:
> > cppcheck picked up that there were a couple of missing va_end()
> > calls in functions using va_start().
> >
> > Signed-off-by: Daniel Axtens <dja@axtens.net>
> Hey Daniel,
>
> It's probably not worth a V2 but I think this could use a commit title that's a
> bit more detailed. Right now it doesn't really allude to what it fixes or what
> it affects.
Yeah, the change log is OK, but the actual subject is a bit terse.
I changed it to "powerpc: Add missing calls to va_end()".
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc: add va_end()
2015-12-17 12:24 ` Michael Ellerman
@ 2015-12-18 1:58 ` Daniel Axtens
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Axtens @ 2015-12-18 1:58 UTC (permalink / raw)
To: Michael Ellerman, Russell Currey, linuxppc-dev
Hi all,
Yes, sorry, that was a bit lax of me.
Michael, your title sounds good.
Thanks!
Regards,
Daniel
> On Thu, 2015-12-17 at 23:09 +1100, Russell Currey wrote:
>> On Thu, 2015-12-17 at 19:41 +1100, Daniel Axtens wrote:
>> > cppcheck picked up that there were a couple of missing va_end()
>> > calls in functions using va_start().
>> >
>> > Signed-off-by: Daniel Axtens <dja@axtens.net>
>> Hey Daniel,
>>
>> It's probably not worth a V2 but I think this could use a commit title that's a
>> bit more detailed. Right now it doesn't really allude to what it fixes or what
>> it affects.
>
> Yeah, the change log is OK, but the actual subject is a bit terse.
>
> I changed it to "powerpc: Add missing calls to va_end()".
>
> cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: powerpc: add va_end()
2015-12-17 8:41 [PATCH] powerpc: add va_end() Daniel Axtens
2015-12-17 12:09 ` Russell Currey
@ 2016-01-11 9:14 ` Michael Ellerman
1 sibling, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2016-01-11 9:14 UTC (permalink / raw)
To: Daniel Axtens, linuxppc-dev; +Cc: Daniel Axtens
On Thu, 2015-17-12 at 08:41:00 UTC, Daniel Axtens wrote:
> cppcheck picked up that there were a couple of missing va_end()
> calls in functions using va_start().
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> Reviewed-by: Russell Currey <ruscur@russell.cc>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/1b855e167b90fcb353977c0893
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-11 9:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-17 8:41 [PATCH] powerpc: add va_end() Daniel Axtens
2015-12-17 12:09 ` Russell Currey
2015-12-17 12:24 ` Michael Ellerman
2015-12-18 1:58 ` Daniel Axtens
2016-01-11 9:14 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).