Re: [PATCH] powerpc/fsl: Update fman dt binding with pcs-phy and tbi-phy

[Scott Wood <scottwood@freescale.com>]

On Tue, 2015-12-22 at 06:18 +0200, igal.liberman@freescale.com wrote:
> From: Igal Liberman <igal.liberman@freescale.com>
> 
> Signed-off-by: Igal Liberman <igal.liberman@freescale.com>
> ---
>  .../devicetree/bindings/powerpc/fsl/fman.txt       |   39
> ++++++++++++++++++++
>  1 file changed, 39 insertions(+)

Some description in the log would be nice, especially why it can't use phy
-handle

> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> index 1fc5328..7a6d7c3 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> @@ -315,6 +315,16 @@ PROPERTIES
>  		Value type: <phandle>
>  		Definition: A phandle for 1EEE1588 timer.
>  
> +- pcsphy-handle
> +		Usage required for "fsl,fman-memac" MACs
> +		Value type: <phandle>
> +		Definition: A phandle for pcsphy.
> +
> +- tbi-handle
> +		Usage required for "fsl,fman-dtsec" MACs
> +		Value type: <phandle>
> +		Definition: A phandle for tbiphy.
> +
>  EXAMPLE
>  
>  fman1_tx28: port@a8000 {
> @@ -340,6 +350,7 @@ ethernet@e0000 {
>  	reg = <0xe0000 0x1000>;
>  	fsl,fman-ports = <&fman1_rx8 &fman1_tx28>;
>  	ptp-timer = <&ptp-timer>;
> +	tbi-handle = <&tbi0>;
>  };
>  
>  ===========================================================================
> =
> @@ -415,6 +426,13 @@ PROPERTIES
>  		The settings and programming routines for internal/external
>  		MDIO are different. Must be included for internal MDIO.
>  
> +For internal PHY device on internal mdio bus, a PHY node should be created.
> +See the definition of the PHY node in booting-without-of.txt for an
> +example of how to define a PHY (Internal PHY has no interrupt line).
> +- For "fsl,fman-mdio" compatible internal mdio bus, the PHY is TBI PHY.
> +- For "fsl,fman-memac-mdio" compatible internal mdio bus, the PHY is PCS
> PHY,
> +  PCS PHY addr must be '0'.
> +
>  EXAMPLE
>  
>  Example for FMan v2 external MDIO:
> @@ -425,12 +443,28 @@ mdio@f1000 {
>  	interrupts = <101 2 0 0>;
>  };
>  
> +Example for FMan v2 internal MDIO:
> +
> +mdio@e3120 {
> +	compatible = "fsl,fman-mdio";
> +	reg = <0xe3120 0xee0>;
> +	fsl,fman-internal-mdio;
> +
> +	tbi1: tbi-phy@8 {
> +		reg = <0x8>;
> +		device_type = "tbi-phy";
> +	};
> +};
> +
>  Example for FMan v3 internal MDIO:
>  
>  mdio@f1000 {
>  	compatible = "fsl,fman-memac-mdio";
>  	reg = <0xf1000 0x1000>;
>  	fsl,fman-internal-mdio;
> +
> +	pcsphy6: ethernet-phy@0 {
> +		reg = <0x0>;
>  };

missing }

-Scott