linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linuxppc-dev@ozlabs.org, Anton Blanchard <anton@samba.org>,
	amodra@gmail.com, ulrich.weigand@de.ibm.com
Subject: Re: [PATCH 1/2] scripts/recordmcount.pl: support data in text section on powerpc
Date: Wed, 13 Jan 2016 09:43:29 +1100	[thread overview]
Message-ID: <1452638609.14097.0.camel@ellerman.id.au> (raw)
In-Reply-To: <20160112104223.4317df9c@gandalf.local.home>

On Tue, 2016-01-12 at 10:42 -0500, Steven Rostedt wrote:
> On Tue, 12 Jan 2016 23:14:22 +1100
> Michael Ellerman <mpe@ellerman.id.au> wrote:
> > From: Ulrich Weigand <ulrich.weigand@de.ibm.com>
> > 
> > If a text section starts out with a data blob before the first
> > function start label, disassembly parsing doing in recordmcount.pl
> > gets confused on powerpc, leading to creation of corrupted module
> > objects.
> > 
> > This was not a problem so far since the compiler would never create
> > such text sections.  However, this has changed with a recent change
> > in GCC 6 to support distances of > 2GB between a function and its
> > assoicated TOC in the ELFv2 ABI, exposing this problem.
> > 
> > There is already code in recordmcount.pl to handle such data blobs
> > on the sparc64 platform.  This patch uses the same method to handle
> > those on powerpc as well.
> > 
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> > ---
> >  scripts/recordmcount.pl | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > Steve can we get an ack for this one, to go via powerpc? cheers
> 
> Acked-by: Steven Rostedt <rostedt@goodmis.org>

Thanks.

  reply	other threads:[~2016-01-12 22:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 12:14 [PATCH 1/2] scripts/recordmcount.pl: support data in text section on powerpc Michael Ellerman
2016-01-12 12:14 ` [PATCH 2/2] powerpc/module: Handle R_PPC64_ENTRY relocations Michael Ellerman
2016-01-13 13:09   ` [2/2] " Michael Ellerman
2016-01-12 15:42 ` [PATCH 1/2] scripts/recordmcount.pl: support data in text section on powerpc Steven Rostedt
2016-01-12 22:43   ` Michael Ellerman [this message]
2016-01-13 13:09 ` [1/2] " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452638609.14097.0.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=amodra@gmail.com \
    --cc=anton@samba.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=rostedt@goodmis.org \
    --cc=ulrich.weigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).