From: Michael Neuling <mikey@neuling.org>
To: Cyril Bur <cyrilbur@gmail.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH V2 8/8] powerpc: Add the ability to save VSX without giving it up
Date: Mon, 18 Jan 2016 15:29:06 +1100 [thread overview]
Message-ID: <1453091346.28504.8.camel@neuling.org> (raw)
In-Reply-To: <20160118131052.7e3e02d9@camb691>
> > Also, put the #ifdef junk as part of the function so that the caller
> > doesn't have to deal with it.=20
> >=20
>=20
> Can do absolutely, however this means that in save_all I can't check if t=
he
> function needs to be called or not. For example, without CONFIG_VSX, MSR_=
VSX
> won't exist which means we might end up calling save_vsx THEN checking MS=
R_VSX
> and returning early.
MSR_VSX should exist even without CONFIG_VSX, so you should be able to
do it.
> I'm happy to defer to you and mpe on what's nicer, I would side with avoi=
ding
> the function call at the cost of ugly #ifdefs but I can always see the me=
rits
> of clean code.
I'd prefer the cleanup. This code has been pretty bad in the past for
being a bit of an #ifdef mess, so it'd be nice to clean it up a bit if
possible.
Mikey
prev parent reply other threads:[~2016-01-18 4:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 5:04 [PATCH V2 0/8] FP/VEC/VSX switching optimisations Cyril Bur
2016-01-15 5:04 ` [PATCH V2 1/8] selftests/powerpc: Test the preservation of FPU and VMX regs across syscall Cyril Bur
2016-01-15 5:04 ` [PATCH V2 2/8] selftests/powerpc: Test preservation of FPU and VMX regs across preemption Cyril Bur
2016-01-15 5:04 ` [PATCH V2 3/8] selftests/powerpc: Test FPU and VMX regs in signal ucontext Cyril Bur
2016-01-15 5:04 ` [PATCH V2 4/8] powerpc: Explicitly disable math features when copying thread Cyril Bur
2016-01-15 5:42 ` Michael Neuling
2016-01-15 5:54 ` Cyril Bur
2016-01-15 6:04 ` Michael Neuling
2016-01-15 5:04 ` [PATCH V2 5/8] powerpc: Restore FPU/VEC/VSX if previously used Cyril Bur
2016-01-15 6:02 ` Michael Neuling
2016-01-18 2:05 ` Cyril Bur
2016-01-15 5:04 ` [PATCH V2 6/8] powerpc: Add the ability to save FPU without giving it up Cyril Bur
2016-01-15 6:08 ` Michael Neuling
2016-01-15 7:38 ` Denis Kirjanov
2016-01-15 7:42 ` Denis Kirjanov
2016-01-15 5:04 ` [PATCH V2 7/8] powerpc: Add the ability to save Altivec " Cyril Bur
2016-01-15 5:04 ` [PATCH V2 8/8] powerpc: Add the ability to save VSX " Cyril Bur
2016-01-15 6:25 ` Michael Neuling
2016-01-18 2:10 ` Cyril Bur
2016-01-18 4:29 ` Michael Neuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453091346.28504.8.camel@neuling.org \
--to=mikey@neuling.org \
--cc=cyrilbur@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).