From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
keescook@chromium.org, akpm@linux-foundation.org,
mingo@kernel.org, hpa@zytor.com, heiko.carstens@de.ibm.com,
benh@kernel.crashing.org, mpe@ellerman.id.au, mmarek@suse.cz,
rusty@rustcorp.com.au, arnd@arndb.de, linux-arch@vger.kernel.org,
linux@roeck-us.net
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v4 1/3] x86: kallsyms: disable absolute percpu symbols on !SMP
Date: Mon, 25 Jan 2016 15:19:30 +0100 [thread overview]
Message-ID: <1453731572-18448-2-git-send-email-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <1453731572-18448-1-git-send-email-ard.biesheuvel@linaro.org>
scripts/kallsyms.c has a special --absolute-percpu command line
option which deals with the zero based per cpu offsets that are
used when building for SMP on x86_64. This means that the option
should only be passed in that case, so add a check for CONFIG_SMP.
Otherwise, per cpu variables are recorded as absolute quantities,
(which they are not under !CONFIG_SMP) and they are not relocated
under CONFIG_RELOCATABLE=y.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
scripts/link-vmlinux.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index ba6c34ea5429..b541c21072f2 100755
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -86,7 +86,7 @@ kallsyms()
kallsymopt="${kallsymopt} --page-offset=$CONFIG_PAGE_OFFSET"
fi
- if [ -n "${CONFIG_X86_64}" ]; then
+ if [ -n "${CONFIG_X86_64}" ] && [ -n "${CONFIG_SMP}" ]; then
kallsymopt="${kallsymopt} --absolute-percpu"
fi
--
2.5.0
next prev parent reply other threads:[~2016-01-25 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 14:19 [PATCH v4 0/3] kallsyms base relative series Ard Biesheuvel
2016-01-25 14:19 ` Ard Biesheuvel [this message]
2016-01-25 14:19 ` [PATCH v4 2/3] kallsyms: don't overload absolute symbol type for percpu symbols Ard Biesheuvel
2016-01-25 14:19 ` [PATCH v4 3/3] kallsyms: add support for relative offsets in kallsyms address table Ard Biesheuvel
2016-01-25 17:44 ` [PATCH v4 0/3] kallsyms base relative series Guenter Roeck
2016-01-25 18:53 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453731572-18448-2-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mmarek@suse.cz \
--cc=mpe@ellerman.id.au \
--cc=rusty@rustcorp.com.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).