From: Scott Wood <oss@buserror.net>
To: Saurabh Sengar <saurabh.truth@gmail.com>,
qiang.zhao@freescale.com, christophe.leroy@c-s.fr,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] QE: Use GFP_ATOMIC while spin_lock_irqsave is held
Date: Mon, 25 Jan 2016 18:52:54 -0600 [thread overview]
Message-ID: <1453769574.27129.14.camel@buserror.net> (raw)
In-Reply-To: <1453618446-6857-1-git-send-email-saurabh.truth@gmail.com>
On Sun, 2016-01-24 at 12:24 +0530, Saurabh Sengar wrote:
> cpm_muram_alloc_common is called twice and both the times
> spin_lock_irqsave is held.
> Using GFP_KERNEL can sleep in spin_lock_irqsave context and cause
> deadlock
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
> ---
> Let me know if there is any other way to fix it.
> Also, I would say this function should be static as it is not used in any
> other file
> drivers/soc/fsl/qe/qe_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Yes, it should be static. Do you plan to send a patch for that?
-Scott
prev parent reply other threads:[~2016-01-26 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 6:54 [PATCH] QE: Use GFP_ATOMIC while spin_lock_irqsave is held Saurabh Sengar
2016-01-26 0:52 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453769574.27129.14.camel@buserror.net \
--to=oss@buserror.net \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.zhao@freescale.com \
--cc=saurabh.truth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).