From: Scott Wood <oss@buserror.net>
To: Thomas Gleixner <tglx@linutronix.de>, Zhao Qiang <qiang.zhao@nxp.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
leoyang.li@nxp.com, xiaobo.xie@nxp.com
Subject: Re: [PATCH] qe_ic: fix a buffer overflow error and add check elsewhere
Date: Tue, 26 Jan 2016 12:08:49 -0600 [thread overview]
Message-ID: <1453831729.27129.35.camel@buserror.net> (raw)
In-Reply-To: <alpine.DEB.2.11.1601261830120.3886@nanos>
On Tue, 2016-01-26 at 18:31 +0100, Thomas Gleixner wrote:
> On Thu, 21 Jan 2016, Zhao Qiang wrote:
>
> > 127 is the theoretical up boundary of QEIC number,
> > in fact there only be 44 qe_ic_info now.
> > add check to overflow for qe_ic_info
>
> How do you trigger that overflow? The above does not explain WHY we need
> these
> checks.
The check in qe_ic_host_map can be triggered by bad data in a device tree.
The set_priority functions do not appear to be used at all.
>
> > diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
> > index 5419527..90c00b7 100644
> > --- a/drivers/soc/fsl/qe/qe_ic.c
> > +++ b/drivers/soc/fsl/qe/qe_ic.c
>
> Sigh. Another dump ground for SOC stuff?
Another? Where are the others, besides arch?
> irq chip drivers belong into drivers/irqchip.
Yes. This stuff was recently moved out of arch/powerpc to work toward being
able to use it on ARM. I'm expecting followup patches to move things like
this that belong elsewhere.
-Scott
prev parent reply other threads:[~2016-01-26 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 1:06 [PATCH] qe_ic: fix a buffer overflow error and add check elsewhere Zhao Qiang
2016-01-22 9:15 ` Leo Li
2016-01-26 17:31 ` Thomas Gleixner
2016-01-26 18:08 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453831729.27129.35.camel@buserror.net \
--to=oss@buserror.net \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.zhao@nxp.com \
--cc=tglx@linutronix.de \
--cc=xiaobo.xie@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).