From: Michael Ellerman <mpe@ellerman.id.au>
To: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: x86@kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, Joe Perches <joe@perches.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Daniel Borkmann <daniel@iogearbox.net>,
Amitkumar Karwar <akarwar@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Kalle Valo <kvalo@codeaurora.org>,
Steve French <sfrench@samba.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] param: convert some "on"/"off" users to strtobool
Date: Fri, 29 Jan 2016 14:15:58 +1100 [thread overview]
Message-ID: <1454037358.30708.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1453990627-19164-4-git-send-email-keescook@chromium.org>
On Thu, 2016-01-28 at 06:17 -0800, Kees Cook wrote:
> This changes several users of manual "on"/"off" parsing to use strtobool.
You should probably point out that it's a slight behaviour change for some
users. ie. parameters that previously *only* worked with "on"/"off", can now
also take 0/1/y/n etc.
But I don't think that's a show stopper.
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Cc: x86@kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-s390@vger.kernel.org
> ---
> arch/powerpc/kernel/rtasd.c | 10 +++-------
> arch/powerpc/platforms/pseries/hotplug-cpu.c | 11 +++--------
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
prev parent reply other threads:[~2016-01-29 3:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 14:17 [PATCH 0/3] lib: add "on" and "off" to strtobool Kees Cook
2016-01-28 14:17 ` [PATCH 1/3] lib: fix callers of strtobool to use char array Kees Cook
2016-02-01 13:17 ` Andy Shevchenko
2016-02-04 18:56 ` Kees Cook
2016-01-28 14:17 ` [PATCH 2/3] lib: add "on" and "off" to strtobool Kees Cook
2016-01-28 14:17 ` [PATCH 3/3] param: convert some "on"/"off" users " Kees Cook
2016-01-28 15:27 ` Heiko Carstens
2016-01-29 3:15 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454037358.30708.1.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akarwar@marvell.com \
--cc=akpm@linux-foundation.org \
--cc=daniel@iogearbox.net \
--cc=heiko.carstens@de.ibm.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=schwidefsky@de.ibm.com \
--cc=sfrench@samba.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).