From: Scott Wood <oss@buserror.net>
To: Raghav Dogra <raghav@freescale.com>,
linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>
Cc: prabhakar.kushwaha@nxp.com, Jaiprakash Singh <b44839@freescale.com>
Subject: Re: [PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers
Date: Mon, 01 Feb 2016 16:26:51 -0600 [thread overview]
Message-ID: <1454365611.2486.18.camel@buserror.net> (raw)
In-Reply-To: <1454323598-5149-3-git-send-email-raghav@freescale.com>
On Mon, 2016-02-01 at 16:16 +0530, Raghav Dogra wrote:
> /*
> * IFC Controller Registers
> */
> -struct fsl_ifc_regs {
> +struct fsl_ifc_fcm {
> __be32 ifc_rev;
> u32 res1[0x2];
> struct {
This struct is not specific to fcm (i.e. nand). Please choose a better name,
such as fsl_ifc_global (which would match "gregs").
-Scott
prev parent reply other threads:[~2016-02-01 22:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 10:46 [PATCH 1/3] driver/memory: Removal of deprecated NO_IRQ Raghav Dogra
2016-02-01 10:46 ` [PATCH 2/3] driver/memory: Update dependency of IFC for Layerscape Raghav Dogra
2016-05-16 0:21 ` [2/3] " Scott Wood
2016-02-01 10:46 ` [PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers Raghav Dogra
2016-02-01 19:41 ` Li Yang
2016-02-01 20:43 ` Brian Norris
2016-02-01 22:26 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454365611.2486.18.camel@buserror.net \
--to=oss@buserror.net \
--cc=b44839@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=prabhakar.kushwaha@nxp.com \
--cc=raghav@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).