From: Joe Perches <joe@perches.com>
To: Luis Henriques <luis.henriques@canonical.com>,
Geoff Levand <geoff@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h>
Date: Sun, 07 Feb 2016 10:26:51 -0800 [thread overview]
Message-ID: <1454869611.3739.8.camel@perches.com> (raw)
In-Reply-To: <1454866730-10481-2-git-send-email-luis.henriques@canonical.com>
On Sun, 2016-02-07 at 17:38 +0000, Luis Henriques wrote:
> Instead of defining a local version of struct ethhdr use the standard
> definition from .
trivia:
> diff --git a/arch/powerpc/platforms/ps3/gelic_udbg.c b/arch/powerpc/platforms/ps3/gelic_udbg.c
[]
> @@ -173,8 +169,8 @@ static void gelic_debug_init(void)
>
> h_eth = (struct ethhdr *)dbg.pkt;
>
> - memset(&h_eth->dest, 0xff, 6);
> - memcpy(&h_eth->src, &mac, 6);
> + memset(&h_eth->h_dest, 0xff, 6);
> + memcpy(&h_eth->h_source, &mac, 6);
Be nice to use ETH_ALEN and eth_broadcast_addr.
Maybe ether_addr_copy too.
> @@ -183,7 +179,7 @@ static void gelic_debug_init(void)
> GELIC_LV1_VLAN_TX_ETHERNET_0, 0, 0,
> &vlan_id, &v2);
> if (!result) {
> - h_eth->type = 0x8100;
> + h_eth->h_proto= 0x8100;
ETH_P_8021Q
> header_size += sizeof(struct vlantag);
> h_vlan = (struct vlantag *)(h_eth + 1);
> @@ -191,7 +187,7 @@ static void gelic_debug_init(void)
> h_vlan->subtype = 0x0800;
> h_ip = (struct iphdr *)(h_vlan + 1);
> } else {
> - h_eth->type = 0x0800;
> + h_eth->h_proto= 0x0800;
ETH_P_IP
next prev parent reply other threads:[~2016-02-07 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 17:38 [PATCH 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs Luis Henriques
2016-02-07 17:38 ` [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h> Luis Henriques
2016-02-07 18:26 ` Joe Perches [this message]
2016-02-08 22:04 ` Luis Henriques
2016-02-07 17:38 ` [PATCH 2/4] powerpc/ps3: gelic_udbg: use struct vlan_hdr from <linux/if_vlan.h> Luis Henriques
2016-02-07 17:38 ` [PATCH 3/4] powerpc/ps3: gelic_udbg: use struct iphdr from <linux/ip.h> Luis Henriques
2016-02-07 17:38 ` [PATCH 4/4] powerpc/ps3: gelic_udbg: use struct udphdr from <linux/udp.h> Luis Henriques
2016-02-08 8:31 ` [PATCH 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs Geert Uytterhoeven
2016-02-08 22:10 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454869611.3739.8.camel@perches.com \
--to=joe@perches.com \
--cc=benh@kernel.crashing.org \
--cc=geoff@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luis.henriques@canonical.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).