From: Michael Ellerman <mpe@ellerman.id.au>
To: Steven Rostedt <rostedt@goodmis.org>,
Denis Kirjanov <kda@linux-powerpc.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] powerpc: tracing: don't trace hcalls on offline CPUs
Date: Tue, 09 Feb 2016 20:24:41 +1100 [thread overview]
Message-ID: <1455009881.13384.1.camel@ellerman.id.au> (raw)
In-Reply-To: <20160205093647.79ca2f70@gandalf.local.home>
On Fri, 2016-02-05 at 09:36 -0500, Steven Rostedt wrote:
> On Fri, 5 Feb 2016 14:20:17 +0300
> Denis Kirjanov <kda@linux-powerpc.org> wrote:
> > > > > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
> > >
> > > Hi Steven,
> > >
> > > please apply with Michael's acked-by tag.
> >
> > ping
>
> Actually, can you take this through the ppc tree? The
> TRACE_EVENT_FN_COND is already in mainline.
>
> You can add my:
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
Thanks, will do.
I tidied up the change log a bit:
powerpc/pseries: Don't trace hcalls on offline CPUs
If a cpu is hotplugged while the hcall trace points are active, it's
possible to hit a warning from RCU due to the trace points calling into
RCU from an offline cpu, eg:
RCU used illegally from offline CPU!
rcu_scheduler_active = 1, debug_locks = 1
Make the hypervisor tracepoints conditional by using
TRACE_EVENT_FN_COND.
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
next prev parent reply other threads:[~2016-02-09 9:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 20:18 [PATCH v3 1/2] tracing: introduce TRACE_EVENT_FN_COND macro Denis Kirjanov
2015-12-14 20:18 ` [PATCH v3 2/2] powerpc: tracing: don't trace hcalls on offline CPUs Denis Kirjanov
2015-12-23 16:12 ` Steven Rostedt
2016-01-12 10:53 ` Denis Kirjanov
2016-01-12 11:53 ` Michael Ellerman
2016-01-19 11:53 ` Denis Kirjanov
2016-02-05 11:20 ` Denis Kirjanov
2016-02-05 14:36 ` Steven Rostedt
2016-02-05 14:48 ` Denis Kirjanov
2016-02-09 9:24 ` Michael Ellerman [this message]
2016-02-09 12:16 ` [v3,2/2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455009881.13384.1.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=kda@linux-powerpc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).