linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: james.bottomley@hansenpartnership.com
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	nfont@linux.vnet.ibm.com, brking@linux.vnet.ibm.com,
	jthumshirn@suse.de, manoj@linux.vnet.ibm.com,
	Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Subject: [PATCH v2 7/7] ibmvscsi: use H_CLOSED instead of magic number
Date: Wed, 10 Feb 2016 19:32:28 -0600	[thread overview]
Message-ID: <1455154348-3226-8-git-send-email-tyreld@linux.vnet.ibm.com> (raw)
In-Reply-To: <1455154348-3226-1-git-send-email-tyreld@linux.vnet.ibm.com>

In a couple places the magic value of 2 is used to check the return
code of hypercalls. This translates to H_CLOSED.

Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
---
 drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 6025481..d9534ee 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -314,7 +314,7 @@ static int ibmvscsi_reset_crq_queue(struct crq_queue *queue,
 	rc = plpar_hcall_norets(H_REG_CRQ,
 				vdev->unit_address,
 				queue->msg_token, PAGE_SIZE);
-	if (rc == 2) {
+	if (rc == H_CLOSED) {
 		/* Adapter is good, but other end is not ready */
 		dev_warn(hostdata->dev, "Partner adapter not ready\n");
 	} else if (rc != 0) {
@@ -364,7 +364,7 @@ static int ibmvscsi_init_crq_queue(struct crq_queue *queue,
 		rc = ibmvscsi_reset_crq_queue(queue,
 					      hostdata);
 
-	if (rc == 2) {
+	if (rc == H_CLOSED) {
 		/* Adapter is good, but other end is not ready */
 		dev_warn(hostdata->dev, "Partner adapter not ready\n");
 		retrc = 0;
-- 
2.5.0

  parent reply	other threads:[~2016-02-11  1:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11  1:32 [PATCH v2 0/7] ibmvscsi code cleanup Tyrel Datwyler
2016-02-11  1:32 ` [PATCH v2 1/7] ibmvscsi: Correct values for several viosrp_crq_format enums Tyrel Datwyler
2016-02-12 14:29   ` Manoj Kumar
2016-02-11  1:32 ` [PATCH v2 2/7] ibmvscsi: Add and use enums for valid CRQ header values Tyrel Datwyler
2016-02-11  8:51   ` Johannes Thumshirn
2016-02-12 14:23   ` Manoj Kumar
2016-02-11  1:32 ` [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines Tyrel Datwyler
2016-02-12 16:43   ` James Bottomley
2016-02-12 16:51     ` Tyrel Datwyler
2016-02-12 16:53       ` James Bottomley
2016-02-12 16:57         ` Martin K. Petersen
2016-02-17  3:03       ` Martin K. Petersen
2016-02-17  8:05         ` Johannes Thumshirn
2016-02-12 22:06   ` Manoj Kumar
2016-02-11  1:32 ` [PATCH v2 4/7] ibmvscsi: Use of_root to access OF device tree root node Tyrel Datwyler
2016-02-11  1:32 ` [PATCH v2 5/7] ibmvscsi: Remove unsupported host config MAD Tyrel Datwyler
2016-02-11  8:53   ` Johannes Thumshirn
2016-02-11  1:32 ` [PATCH v2 6/7] ibmvscsi: Add endian conversions to sysfs attribute show functions Tyrel Datwyler
2016-02-11  1:32 ` Tyrel Datwyler [this message]
2016-02-11  8:54   ` [PATCH v2 7/7] ibmvscsi: use H_CLOSED instead of magic number Johannes Thumshirn
2016-02-12 16:55 ` [PATCH v2 0/7] ibmvscsi code cleanup Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455154348-3226-8-git-send-email-tyreld@linux.vnet.ibm.com \
    --to=tyreld@linux.vnet.ibm.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=manoj@linux.vnet.ibm.com \
    --cc=martin.petersen@oracle.com \
    --cc=nfont@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).