From: Scott Wood <oss@buserror.net>
To: Alessio Igor Bogani <alessio.bogani@elettra.eu>,
Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: powerpc/86xx: Use config fragments approach
Date: Wed, 10 Feb 2016 21:22:37 -0600 [thread overview]
Message-ID: <1455160957.2463.14.camel@buserror.net> (raw)
In-Reply-To: <1455096160-5868-1-git-send-email-alessio.bogani@elettra.eu>
On Wed, 2016-02-10 at 10:22 +0100, Alessio Igor Bogani wrote:
> Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> ---
> arch/powerpc/Makefile | 10 +
> arch/powerpc/configs/86xx-32bit.config | 4 +
> arch/powerpc/configs/86xx-hw.config | 106 +++++++++
> arch/powerpc/configs/86xx-smp.config | 2 +
> arch/powerpc/configs/86xx/gef_ppc9a_defconfig | 216 ------------------
> arch/powerpc/configs/86xx/gef_sbc310_defconfig | 214 ------------------
> arch/powerpc/configs/86xx/gef_sbc610_defconfig | 273 --------------------
> ---
> arch/powerpc/configs/86xx/mpc8610_hpcd_defconfig | 110 ---------
> arch/powerpc/configs/86xx/mpc8641_hpcn_defconfig | 156 -------------
> arch/powerpc/configs/86xx/sbc8641d_defconfig | 246 --------------------
> arch/powerpc/configs/mpc86xx_basic_defconfig | 6 +
> arch/powerpc/configs/mpc86xx_defconfig | 162 --------------
> 12 files changed, 128 insertions(+), 1377 deletions(-)
> create mode 100644 arch/powerpc/configs/86xx-32bit.config
> create mode 100644 arch/powerpc/configs/86xx-hw.config
> create mode 100644 arch/powerpc/configs/86xx-smp.config
> delete mode 100644 arch/powerpc/configs/86xx/gef_ppc9a_defconfig
> delete mode 100644 arch/powerpc/configs/86xx/gef_sbc310_defconfig
> delete mode 100644 arch/powerpc/configs/86xx/gef_sbc610_defconfig
> delete mode 100644 arch/powerpc/configs/86xx/mpc8610_hpcd_defconfig
> delete mode 100644 arch/powerpc/configs/86xx/mpc8641_hpcn_defconfig
> delete mode 100644 arch/powerpc/configs/86xx/sbc8641d_defconfig
> create mode 100644 arch/powerpc/configs/mpc86xx_basic_defconfig
> delete mode 100644 arch/powerpc/configs/mpc86xx_defconfig
Why do your patches not start with [PATCH]?
How does the resulting config compare to the individual previous configs? Are
there any options that were dropped from the union of the old configs?
Mutually exclusive options that had to be resolved one way or another?
Changes in non-hw options?
It would be nice to do what I did with 85xx in commit 7e2ad2ef851, and start
with a patch that makes the defconfigs conform to what the new approach will
give (to more easily see what is changing), and then have the next patch
switch to fragments.
> diff --git a/arch/powerpc/configs/86xx-32bit.config
> b/arch/powerpc/configs/86xx-32bit.config
> new file mode 100644
> index 0000000..8a2c6ff
> --- /dev/null
> +++ b/arch/powerpc/configs/86xx-32bit.config
> @@ -0,0 +1,4 @@
> +CONFIG_HIGHMEM=y
> +CONFIG_KEXEC=y
> +CONFIG_PPC_86xx=y
> +CONFIG_PROC_KCORE=y
Why is this not in mpc86xx_basic_defconfig? There is no 64-bit 86xx.
-Scott
prev parent reply other threads:[~2016-02-11 3:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 9:22 powerpc/86xx: Use config fragments approach Alessio Igor Bogani
2016-02-11 3:22 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455160957.2463.14.camel@buserror.net \
--to=oss@buserror.net \
--cc=alessio.bogani@elettra.eu \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).