From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Subject: [PATCH V11_RESEND 08/10] powerpc/perf: Change POWER8 PMU configuration to work with SW filters
Date: Tue, 16 Feb 2016 12:07:08 +0530 [thread overview]
Message-ID: <1455604630-16214-9-git-send-email-khandual@linux.vnet.ibm.com> (raw)
In-Reply-To: <1455604630-16214-1-git-send-email-khandual@linux.vnet.ibm.com>
The kernel now supports SW based branch filters for book3s systems with
some specific requirements while dealing with HW supported branch filters
in order to achieve overall OR semantics prevailing in perf branch stack
sampling framework. This patch adapts the BHRB branch filter configuration
to meet those protocols. POWER8 PMU can only handle one HW based branch
filter request at any point of time. For all other combinations PMU will
pass it on to the SW.
Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
---
arch/powerpc/perf/power8-pmu.c | 51 ++++++++++++++++++++++++++++++++++++------
1 file changed, 44 insertions(+), 7 deletions(-)
diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf/power8-pmu.c
index 3d819cb..ee8a68a 100644
--- a/arch/powerpc/perf/power8-pmu.c
+++ b/arch/powerpc/perf/power8-pmu.c
@@ -656,6 +656,16 @@ static int power8_generic_events[] = {
static u64 power8_bhrb_filter_map(u64 branch_sample_type, u64 *bhrb_filter)
{
+ u64 x, pmu_bhrb_filter;
+
+ pmu_bhrb_filter = 0;
+ *bhrb_filter = 0;
+
+ if (branch_sample_type & PERF_SAMPLE_BRANCH_ANY) {
+ *bhrb_filter = PERF_SAMPLE_BRANCH_ANY;
+ return pmu_bhrb_filter;
+ }
+
/* BHRB and regular PMU events share the same privilege state
* filter configuration. BHRB is always recorded along with a
* regular PMU event. As the privilege state filter is handled
@@ -666,18 +676,45 @@ static u64 power8_bhrb_filter_map(u64 branch_sample_type, u64 *bhrb_filter)
/* Ignore user, kernel, hv bits */
branch_sample_type &= ~PERF_SAMPLE_BRANCH_PLM_ALL;
- /* No branch filter requested */
- if (branch_sample_type == PERF_SAMPLE_BRANCH_ANY)
- return 0;
+ /*
+ * POWER8 does not support ORing of PMU HW branch filters. Hence
+ * if multiple branch filters are requested which may include filters
+ * supported in PMU, still go ahead and clear the PMU based HW branch
+ * filter component as in this case all the filters will be processed
+ * in SW.
+ */
if (branch_sample_type & PERF_SAMPLE_BRANCH_CALL)
return -1;
- if (branch_sample_type == PERF_SAMPLE_BRANCH_ANY_CALL)
- return POWER8_MMCRA_IFM1;
+ for_each_branch_sample_type(x) {
+ /* Ignore privilege branch filters */
+ if ((x == PERF_SAMPLE_BRANCH_USER)
+ || (x == PERF_SAMPLE_BRANCH_KERNEL)
+ || (x == PERF_SAMPLE_BRANCH_HV))
+ continue;
+
+ if (!(branch_sample_type & x))
+ continue;
+
+ /* Supported individual PMU branch filters */
+ if (branch_sample_type & PERF_SAMPLE_BRANCH_ANY_CALL) {
+ branch_sample_type &= ~PERF_SAMPLE_BRANCH_ANY_CALL;
+ if (branch_sample_type) {
+ /* Multiple filters will be processed in SW */
+ pmu_bhrb_filter = 0;
+ *bhrb_filter = 0;
+ return pmu_bhrb_filter;
+ } else {
+ /* Individual filter will be processed in HW */
+ pmu_bhrb_filter |= POWER8_MMCRA_IFM1;
+ *bhrb_filter |= PERF_SAMPLE_BRANCH_ANY_CALL;
+ return pmu_bhrb_filter;
+ }
+ }
+ }
- /* Every thing else is unsupported */
- return -1;
+ return pmu_bhrb_filter;
}
static void power8_config_bhrb(u64 pmu_bhrb_filter)
--
2.1.0
next prev parent reply other threads:[~2016-02-16 6:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 6:37 [PATCH V11_RESEND 00/10] powerpc/perf: Enable SW branch filters Anshuman Khandual
2016-02-16 6:37 ` [PATCH V11_RESEND 01/10] powerpc/perf: Change name & type of 'pred' in power_pmu_bhrb_read Anshuman Khandual
2016-02-16 6:37 ` [PATCH V11_RESEND 02/10] powerpc/perf: Re organize PMU branch filter processing on POWER8 Anshuman Khandual
2016-02-16 6:37 ` [PATCH V11_RESEND 03/10] powerpc/perf: Restore privilege level filter support for BHRB Anshuman Khandual
2016-02-16 6:37 ` [PATCH V11_RESEND 04/10] powerpc/perf: Re organize BHRB processing Anshuman Khandual
2016-02-16 6:37 ` [PATCH V11_RESEND 05/10] powerpc/perf: Change the name of HW PMU branch filter tracking variable Anshuman Khandual
2016-02-16 6:37 ` [PATCH V11_RESEND 06/10] powerpc/lib: Add new branch analysis support functions Anshuman Khandual
2016-02-16 6:37 ` [PATCH V11_RESEND 07/10] powerpc/perf: Enable SW filtering in branch stack sampling framework Anshuman Khandual
2016-02-16 6:37 ` Anshuman Khandual [this message]
2016-02-16 6:37 ` [PATCH V11_RESEND 09/10] powerpc/perf: Enable privilege mode SW branch filters Anshuman Khandual
2016-02-16 6:37 ` [PATCH V11_RESEND 10/10] selftests/powerpc: Add test for BHRB branch filters (HW & SW) Anshuman Khandual
2016-02-16 13:08 ` [PATCH V11_RESEND 00/10] powerpc/perf: Enable SW branch filters Christophe Leroy
2016-02-17 3:49 ` Anshuman Khandual
2016-02-17 4:23 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455604630-16214-9-git-send-email-khandual@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).