From: Michael Ellerman <mpe@ellerman.id.au>
To: Russell Currey <ruscur@russell.cc>,
Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] MAINTAINERS: rename EEH from "enhanced" to "extended" error handling
Date: Wed, 17 Feb 2016 13:23:09 +1100 [thread overview]
Message-ID: <1455675789.2956.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1455666599.3357.5.camel@russell.cc>
On Wed, 2016-02-17 at 10:49 +1100, Russell Currey wrote:
> On Wed, 2016-02-17 at 09:58 +1100, Gavin Shan wrote:
> > On Wed, Feb 17, 2016 at 09:49:08AM +1100, Gavin Shan wrote:
> > >
> > > On Tue, Feb 16, 2016 at 07:52:00PM +1100, Russell Currey wrote:
> > > >
> > > > Incredibly, IBM online documentation for EEH uses "extended error
> > > > handling"
> > > > and "enhanced error handling" to refer to the same thing, in
> > > > different
> > > > places. In other parts of the kernel, namely the EEH documentation
> > > > (found
> > > > in Documentation/powerpc/eeh-pci-error-recovery.txt), it's referred
> > > > to as
> > > > "extended", and in my opinion "extended" makes more sense for what
> > > > EEH
> > > > does.
> > > >
> > > > The only place "enhanced error handling" shows up in the kernel is in
> > > > MAINTAINERS, so fix it.
> > > >
> > > Russell, Thanks for fixing it up. Since you're at it, Please replace
> > > the
> > > maintainer to yourself. Also, the components mentioned in this file are
> > > listed in alphabetic order according to their names. As the name of EEH
> > > is changed, it would be put in front of "Extended Verification Module
> > > (EVM)".
> > >
> > I agree with Michael as discussed in another thread: we're going to use
> > "enhanced", not "extended" though some chip datasheet (P7IOC) talks about
> > "extended error handling".
> >
> > Russell, please change the maintainer to you and repost.
> Sure.
>
> While I'm changing MAINTAINERS, what are your thoughts on renaming the EEH
> entry from "ENHANCED ERROR HANDLING (EEH)" to something like "PCI EXTENDED
> ERROR HANDLING (EEH)" or "EXTENDED ERROR HANDLING (EEH) FOR PCI" - so it's
> clear it refers to PCI and not something more generic?
Yep, having PCI at the front would be good as it will sort next to the other
PCI things. Having POWERPC in there is probably also good.
cheers
prev parent reply other threads:[~2016-02-17 2:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 8:52 [PATCH] MAINTAINERS: rename EEH from "enhanced" to "extended" error handling Russell Currey
2016-02-16 10:26 ` Michael Ellerman
2016-02-16 22:49 ` Gavin Shan
2016-02-16 22:58 ` Gavin Shan
2016-02-16 23:49 ` Russell Currey
2016-02-17 0:13 ` Russell Currey
2016-02-17 2:23 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455675789.2956.1.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).