From: Michael Neuling <mikey@neuling.org>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] powerpc: Add POWER9 cputable entry
Date: Wed, 17 Feb 2016 20:10:58 +1100 [thread overview]
Message-ID: <1455700258.17094.56.camel@neuling.org> (raw)
In-Reply-To: <56C40D1A.9060601@linux.vnet.ibm.com>
> > +_GLOBAL(__setup_cpu_power9)
> > + mflr r11
> > + bl __init_FSCR
> > + bl __init_PMU
> Just to keep in mind, I am not sure whether
> powerisa 3.0 support MMCRS spr, so we
> will need a feature check in __init_PMU()
> for power9.
Yeah, I'm not expecting this to work.
I'm trying to lay down a common base we can start working on. There
are lots of people working a bunch different bases. I want to avoid
that and we can do that by upstreaming.
> > + bl __init_hvmode_206
> > + mtlr r11
> > + beqlr
> > + li r0,0
> > + mtspr SPRN_LPID,r0
> > + mfspr r3,SPRN_LPCR
> > + ori r3, r3, LPCR_PECEDH
> > + bl __init_LPCR
> > + bl __init_HFSCR
> > + bl __init_tlb_power9
> > + bl __init_PMU_HV
>=20
> Again, need to check whether powerisa 3.0 support MMCRH spr
> which is used in __init_PMU_HV()
Same here.
> > + { /* Hacked up Power9 */
/me reviews his own patch...
Oops
> > + .pvr_mask =3D 0xffff0000,
> > + .pvr_value =3D 0x004e0000,
> > + .cpu_name =3D "POWER9 (raw)",
> > + .cpu_features =3D CPU_FTRS_POWER9,
> > + .cpu_user_features =3D COMMON_USER_POWER9,
> > + .cpu_user_features2 =3D COMMON_USER2_POWER9,
> > + .mmu_features =3D MMU_FTRS_POWER9,
> > + .icache_bsize =3D 128,
> > + .dcache_bsize =3D 128,
> > + .num_pmcs =3D 6,
> > + .pmc_type =3D PPC_PMC_IBM,
> > + .oprofile_cpu_type =3D "ppc64/power8",
>
> This should be ppc64/power9. We use "oprofile_cpu_type" in PMU init.
Yep, we can fix that up when we post PMU patches, but if I repost I'll
change so it doesn't match with old one.
Mikey
next prev parent reply other threads:[~2016-02-17 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 5:07 [PATCH 1/2] powerpc/powernv: Create separate subcores CPU feature bit Michael Neuling
2016-02-17 5:07 ` [PATCH 2/2] powerpc: Add POWER9 cputable entry Michael Neuling
2016-02-17 6:03 ` Madhavan Srinivasan
2016-02-17 9:10 ` Michael Neuling [this message]
2016-02-17 11:09 ` Michael Ellerman
2016-02-17 12:28 ` oliver
2016-02-17 12:49 ` Michael Ellerman
2016-02-18 3:32 ` Michael Neuling
2016-02-18 10:37 ` Michael Ellerman
2016-02-17 14:59 ` [PATCH 1/2] powerpc/powernv: Create separate subcores CPU feature bit Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455700258.17094.56.camel@neuling.org \
--to=mikey@neuling.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).