From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from host.buserror.net (host.buserror.net [209.198.135.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 9FDAB1A06BA for ; Wed, 2 Mar 2016 01:57:30 +1100 (AEDT) Message-ID: <1456844240.5360.65.camel@buserror.net> From: Scott Wood To: Alessio Igor Bogani Cc: Kumar Gala , linuxppc-dev@lists.ozlabs.org, LKML Date: Tue, 01 Mar 2016 08:57:20 -0600 In-Reply-To: References: <1456397825-1786-1-git-send-email-alessio.bogani@elettra.eu> <1456397825-1786-2-git-send-email-alessio.bogani@elettra.eu> <1456785480.5360.60.camel@buserror.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Subject: Re: [RFC PATCH v1 2/2] powerpc/86xx: Introduce and use common dtsi List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2016-03-01 at 15:55 +0100, Alessio Igor Bogani wrote: > Scott, > > On 29 February 2016 at 23:38, Scott Wood wrote: > [...] > > > > > +&pci0 { > > > + compatible = "fsl,mpc8641-pcie"; > > > + device_type = "pci"; > > > + #size-cells = <2>; > > > + #address-cells = <3>; > > > + bus-range = <0x0 0xff>; > > > + clock-frequency = <33333333>; > > > > The clock frequency of PCI Express is not 33 MHz. > > A lot of dtsi files into fsl directory have got that value! Well, they shouldn't. :-P This isn't the first time I've told someone to take that out. -Scott