From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org, linuxppc-dev@ozlabs.org,
benh@kernel.crashing.org,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Subject: [PATCH 2/2] Fix misleading comment for hard_irq_disable() in pmao_restore_workaround
Date: Fri, 4 Mar 2016 10:31:49 +0530 [thread overview]
Message-ID: <1457067709-15720-2-git-send-email-maddy@linux.vnet.ibm.com> (raw)
In-Reply-To: <1457067709-15720-1-git-send-email-maddy@linux.vnet.ibm.com>
Current comment added in pmao_restore_workaround() for
hard_irq_disable is misleading. Comment should say to hard
"disable" interrupts instead of "enable" it. Patch to fix the typo.
Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
arch/powerpc/perf/core-book3s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c
index d1e65ce545b3..97a1d40d8696 100644
--- a/arch/powerpc/perf/core-book3s.c
+++ b/arch/powerpc/perf/core-book3s.c
@@ -651,7 +651,7 @@ static void pmao_restore_workaround(bool ebb)
/*
* We are already soft-disabled in power_pmu_enable(). We need to hard
- * enable to actually prevent the PMU exception from firing.
+ * disable to actually prevent the PMU exception from firing.
*/
hard_irq_disable();
--
1.9.1
next prev parent reply other threads:[~2016-03-04 5:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 5:01 [PATCH 1/2] Fix misleading comment in early_setup_secondary Madhavan Srinivasan
2016-03-04 5:01 ` Madhavan Srinivasan [this message]
2016-03-11 0:30 ` [2/2] Fix misleading comment for hard_irq_disable() in pmao_restore_workaround Michael Ellerman
2016-06-21 12:27 ` [1/2] Fix misleading comment in early_setup_secondary Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457067709-15720-2-git-send-email-maddy@linux.vnet.ibm.com \
--to=maddy@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).