From: Ian Munsie <imunsie@au1.ibm.com>
To: Matt Ochs <mrochs@us.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Michael Neuling <mikey@neuling.org>,
Manoj Kumar <kumarmn@us.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Michael Ellerman <michaele@au1.ibm.com>
Subject: Re: [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events
Date: Tue, 08 Mar 2016 12:42:38 +1100 [thread overview]
Message-ID: <1457401187-sup-7130@delenn.ozlabs.ibm.com> (raw)
In-Reply-To: <2E3C996E-C050-426F-878D-F25905E3C584@us.ibm.com>
Excerpts from Matt Ochs's message of 2016-03-08 11:26:55 +1100:
> Any reason for adding these extra lines as part of this commit?
mpe asked for some newlines here in the v1 submission, and it only
really made sense to do so if all the related sections had consistent
whitespace as well.
> > +/*
> > + * AFU driver ops allows an AFU driver to create their own events to pass to
> > + * userspace through the file descriptor as a simpler alternative to overriding
> > + * the read() and poll() calls that works with the generic cxl events. These
> > + * events are given priority over the generic cxl events, so will be delivered
>
> so _they_ will be delivered
thanks for spotting that...
> > + *
> > + * even_pending() will be called by the cxl driver to check if an event is
> > + * pending (e.g. in select/poll/read calls).
>
> event_pending() <- missing 't'
...and that.
Cheers,
-Ian
prev parent reply other threads:[~2016-03-08 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 18:59 [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events Ian Munsie
2016-03-07 18:59 ` [PATCH v2 2/2] cxl: add set/get private data to context struct Ian Munsie
2016-03-08 0:28 ` Matt Ochs
2016-03-08 0:26 ` [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events Matt Ochs
2016-03-08 1:42 ` Ian Munsie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457401187-sup-7130@delenn.ozlabs.ibm.com \
--to=imunsie@au1.ibm.com \
--cc=kumarmn@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michaele@au1.ibm.com \
--cc=mikey@neuling.org \
--cc=mrochs@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).