From: Michael Ellerman <mpe@ellerman.id.au>
To: Michael Neuling <mikey@neuling.org>,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
imunsie@au1.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH next] cxl: Allow PSL timebase to not sync
Date: Tue, 15 Mar 2016 14:56:26 +1100 [thread overview]
Message-ID: <1458014186.8059.5.camel@ellerman.id.au> (raw)
In-Reply-To: <1458001649.12098.59.camel@neuling.org>
On Tue, 2016-03-15 at 11:27 +1100, Michael Neuling wrote:
> On Mon, 2016-03-14 at 20:29 +0100, Frederic Barrat wrote:
> > CXL driver synchronizes the PSL timebase with the CAPP during
> > initialization. If it can't synchronize, then the driver currently
> > fails and the cxl adapter is not usable. That behavior is a bit
> > extreme for the time being, as some adapters are known to have
> > troubles syncing their PSL timebase and there are no known use of it.
> >
> > Introduce a psl_timebase module parameter to control whether PSL
> > timebase is required or not. Default is to allow initializaton even
> > if
> > syncing failed.
> > Default behavior will be changed when current issues with some cxl
> > adapters are resolved.
>
> I'm not happy with doing this unless we add something which advertises
> that it's synced or not to userspace.
>
> If we do that, I'm happy to just fail without the need of the parameter
> but advertise it to userspace.
>
> The parameter is a bit of a PITA too, as it's a driver level config not
> card level. You really want to turn it on/off based on the card, not
> the whole system.
And it just sounds like a big hack around broken hardware, which we'll have to
carry for the foreseeable future.
cheers
next prev parent reply other threads:[~2016-03-15 3:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 18:55 [PATCH] cxl: Allow PSL timebase to not sync Frederic Barrat
2016-03-14 19:29 ` [PATCH next] " Frederic Barrat
2016-03-15 0:27 ` Michael Neuling
2016-03-15 3:56 ` Michael Ellerman [this message]
2016-03-16 11:32 ` Frederic Barrat
2016-03-15 4:09 ` Vaibhav Jain
2016-03-15 18:36 ` Frederic Barrat
2016-03-17 1:41 ` Ian Munsie
2016-03-17 2:45 ` Michael Neuling
2016-03-17 20:49 ` Frederic Barrat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458014186.8059.5.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).