From: Russell Currey <ruscur@russell.cc>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powernv/hmi: Use the "unknown" checkstop type as a fallback
Date: Tue, 15 Mar 2016 16:15:19 +1100 [thread overview]
Message-ID: <1458018919.30802.4.camel@russell.cc> (raw)
In-Reply-To: <56E787FE.1060104@au1.ibm.com>
On Tue, 2016-03-15 at 14:56 +1100, Andrew Donnellan wrote:
> On 15/03/16 14:26, Russell Currey wrote:
> >
> > The HMI code knows about three types of errors: CORE, NX and UNKNOWN.
> > If OPAL were to add a new type, it would not be handled at all since
> > there is no fallback case. Instead of explicitly checking for UNKNOWN,
> > treat any checkstop type without a handler as unknown.
> >
> > Signed-off-by: Russell Currey <ruscur@russell.cc>
> Indeed it looks like there isn't a fallback case.
>
> Would it be useful to print xstop_type in the unknown case?
I don't think so - if there's a new checkstop type, specific handling for
it should be implemented in the kernel, and if you're getting unknown
checkstops that are bringing down your machine you should be looking at the
OPAL firmware log anyway, which would contain details if there was
something "new".
>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>
next prev parent reply other threads:[~2016-03-15 5:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 3:26 [PATCH] powernv/hmi: Use the "unknown" checkstop type as a fallback Russell Currey
2016-03-15 3:41 ` Daniel Axtens
2016-03-15 3:56 ` Andrew Donnellan
2016-03-15 5:15 ` Russell Currey [this message]
2016-03-15 5:36 ` Andrew Donnellan
2016-03-15 5:40 ` Russell Currey
2016-03-15 9:28 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458018919.30802.4.camel@russell.cc \
--to=ruscur@russell.cc \
--cc=andrew.donnellan@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).