* [PATCH 1/2] powerpc: Remove orphaned asm implementation of abs()
@ 2016-03-16 10:36 Michael Ellerman
2016-03-16 10:36 ` [PATCH 2/2] powerpc: Make generic_memcpy() private to copy_32.S Michael Ellerman
2016-04-11 12:35 ` [1/2] powerpc: Remove orphaned asm implementation of abs() Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: Michael Ellerman @ 2016-03-16 10:36 UTC (permalink / raw)
To: linuxppc-dev
This has been unused since ~2004, remove it.
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/kernel/misc_32.S | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S
index be8edd67f05b..c0cd779adfc3 100644
--- a/arch/powerpc/kernel/misc_32.S
+++ b/arch/powerpc/kernel/misc_32.S
@@ -684,12 +684,6 @@ _GLOBAL(__bswapdi2)
mr r4,r10
blr
-_GLOBAL(abs)
- srawi r4,r3,31
- xor r3,r3,r4
- sub r3,r3,r4
- blr
-
#ifdef CONFIG_SMP
_GLOBAL(start_secondary_resume)
/* Reset stack */
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] powerpc: Make generic_memcpy() private to copy_32.S
2016-03-16 10:36 [PATCH 1/2] powerpc: Remove orphaned asm implementation of abs() Michael Ellerman
@ 2016-03-16 10:36 ` Michael Ellerman
2016-04-11 12:35 ` [2/2] " Michael Ellerman
2016-04-11 12:35 ` [1/2] powerpc: Remove orphaned asm implementation of abs() Michael Ellerman
1 sibling, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2016-03-16 10:36 UTC (permalink / raw)
To: linuxppc-dev
generic_memcpy() is only called from copy_32.S, so there's no reason for
it to be global.
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/lib/copy_32.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/lib/copy_32.S b/arch/powerpc/lib/copy_32.S
index c44df2dbedd5..99f37f24185c 100644
--- a/arch/powerpc/lib/copy_32.S
+++ b/arch/powerpc/lib/copy_32.S
@@ -217,7 +217,7 @@ _GLOBAL(memcpy)
bdnz 40b
65: blr
-_GLOBAL(generic_memcpy)
+generic_memcpy:
srwi. r7,r5,3
addi r6,r3,-4
addi r4,r4,-4
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [1/2] powerpc: Remove orphaned asm implementation of abs()
2016-03-16 10:36 [PATCH 1/2] powerpc: Remove orphaned asm implementation of abs() Michael Ellerman
2016-03-16 10:36 ` [PATCH 2/2] powerpc: Make generic_memcpy() private to copy_32.S Michael Ellerman
@ 2016-04-11 12:35 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2016-04-11 12:35 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev
On Wed, 2016-16-03 at 10:36:05 UTC, Michael Ellerman wrote:
> This has been unused since ~2004, remove it.
>
> Reported-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc next.
https://git.kernel.org/powerpc/c/b05fac783a75c6e9f3af2ce082
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-11 12:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-16 10:36 [PATCH 1/2] powerpc: Remove orphaned asm implementation of abs() Michael Ellerman
2016-03-16 10:36 ` [PATCH 2/2] powerpc: Make generic_memcpy() private to copy_32.S Michael Ellerman
2016-04-11 12:35 ` [2/2] " Michael Ellerman
2016-04-11 12:35 ` [1/2] powerpc: Remove orphaned asm implementation of abs() Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).